components/nacl/loader/nacl_listener.cc - Issue 1903663004: IPC: Fix attachment brokering race condition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/loader/nacl_listener.cc

Issue 1903663004: IPC: Fix attachment brokering race condition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: runtime error Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/loader/nacl_listener.cc

diff --git a/components/nacl/loader/nacl_listener.cc b/components/nacl/loader/nacl_listener.cc

index 4dfb6801ffde1c84a73c8d30a45ae316eb8380df..9d381c43e1ff4d8c2889275f475028881dd3a840 100644

--- a/components/nacl/loader/nacl_listener.cc

+++ b/components/nacl/loader/nacl_listener.cc

@@ -224,10 +224,10 @@ void NaClListener::Listen() {

&shutdown_event_);

filter_ = channel_->CreateSyncMessageFilter();

channel_->AddFilter(new FileTokenMessageFilter());

- channel_->Init(channel_name, IPC::Channel::MODE_CLIENT, true);

IPC::AttachmentBroker* global = IPC::AttachmentBroker::GetGlobal();

if (global && !global->IsPrivilegedBroker())

global->RegisterBrokerCommunicationChannel(channel_.get());

+ channel_->Init(channel_name, IPC::Channel::MODE_CLIENT, true);

main_loop_ = base::MessageLoop::current();

main_loop_->Run();

}