IPC: Fix attachment brokering race condition.

remoting/host/ipc_util_win.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/ipc_util.h"
 
 #include <utility>
 
 #include "base/files/file.h"
 #include "base/logging.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/win/scoped_handle.h"
 #include "base/win/win_util.h"
+#include "ipc/attachment_broker.h"
 #include "ipc/ipc_channel.h"
 #include "ipc/ipc_channel_proxy.h"
 #include "remoting/host/win/security_descriptor.h"
 
 using base::win::ScopedHandle;
 
 namespace remoting {
 
 // Pipe name prefix used by Chrome IPC channels to convert a channel name into
 // a pipe name.
@@ skipping 23 matching lines @@
   // Generate a unique name for the channel.
   std::string channel_name = IPC::Channel::GenerateUniqueRandomChannelID();
 
   // Create the server end of the channel.
   ScopedHandle pipe;
   if (!CreateIpcChannel(channel_name, security_descriptor, &pipe)) {
     return false;
   }
 
   // Wrap the pipe into an IPC channel.
-  std::unique_ptr<IPC::ChannelProxy> server = IPC::ChannelProxy::Create(
-      IPC::ChannelHandle(pipe.Get()), IPC::Channel::MODE_SERVER, listener,
-      io_task_runner);
+  std::unique_ptr<IPC::ChannelProxy> server(
+      new IPC::ChannelProxy(listener, io_task_runner));
+  IPC::AttachmentBroker::GetGlobal()->RegisterCommunicationChannel(
+      server.get(), io_task_runner);
+  server->Init(IPC::ChannelHandle(pipe.Get()), IPC::Channel::MODE_SERVER,
+                true);
 
   // Convert the channel name to the pipe name.
   std::string pipe_name(kChromePipeNamePrefix);
   pipe_name.append(channel_name);
 
   SECURITY_ATTRIBUTES security_attributes = {0};
   security_attributes.nLength = sizeof(security_attributes);
   security_attributes.lpSecurityDescriptor = nullptr;
   security_attributes.bInheritHandle = TRUE;
 
@@ skipping 54 matching lines @@
     PLOG(ERROR)
         << "Failed to create the server end of the Chromoting IPC channel";
     return false;
   }
 
   *pipe_out = std::move(pipe);
   return true;
 }
 
 } // namespace remoting