Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Side by Side Diff: ipc/ipc_channel_common.cc

Issue 1903663004: IPC: Fix attachment brokering race condition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase (scoped_ptr->std::unique_ptr) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ipc/ipc_channel.h ('k') | ipc/ipc_channel_nacl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "build/build_config.h" 5 #include "build/build_config.h"
6 #include "ipc/ipc_channel.h" 6 #include "ipc/ipc_channel.h"
7 7
8 namespace IPC { 8 namespace IPC {
9 9
10 // static 10 // static
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 return Channel::Create(channel_handle, Channel::MODE_SERVER, listener); 45 return Channel::Create(channel_handle, Channel::MODE_SERVER, listener);
46 } 46 }
47 47
48 Channel::~Channel() { 48 Channel::~Channel() {
49 } 49 }
50 50
51 bool Channel::IsSendThreadSafe() const { 51 bool Channel::IsSendThreadSafe() const {
52 return false; 52 return false;
53 } 53 }
54 54
55 void Channel::OnSetAttachmentBrokerEndpoint() {
56 CHECK(!did_start_connect_);
57 }
58
59 void Channel::WillConnect() {
60 did_start_connect_ = true;
61 }
62
55 } // namespace IPC 63 } // namespace IPC
56 64
OLDNEW
« no previous file with comments | « ipc/ipc_channel.h ('k') | ipc/ipc_channel_nacl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698