Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1903663003: Move InheritanceManager to its own file. (Closed)

Created:
4 years, 8 months ago by Paul Berry
Modified:
4 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move InheritanceManager to its own file. No changes other than code motion. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/8f9defbb505e2418fd57c784c20f8170b2d50647

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1223 lines, -1198 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/override_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart View 1 chunk +1212 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 4 chunks +2 lines, -1196 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong_mode.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/inheritance_manager_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/strong_mode_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 8 months ago (2016-04-20 12:50:18 UTC) #2
Brian Wilkerson
lgtm, but I made some changes to InheritanceManager that will need to be copied forward.
4 years, 8 months ago (2016-04-20 15:16:56 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as 8f9defbb505e2418fd57c784c20f8170b2d50647 (presubmit successful).
4 years, 8 months ago (2016-04-20 15:58:08 UTC) #5
Paul Berry
4 years, 8 months ago (2016-04-20 15:59:14 UTC) #6
Message was sent while issue was closed. 
On 2016/04/20 15:16:56, Brian Wilkerson wrote:
> lgtm, but I made some changes to InheritanceManager that will need to be
copied
> forward.

Thanks for the heads up--this saved me some time investigating the merge
conflict :)

Powered by Google App Engine
This is Rietveld 408576698