Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1903653002: buildbucket: fix instrumentation (Closed)

Created:
4 years, 8 months ago by nodir
Modified:
4 years, 8 months ago
Reviewers:
Sergey Berezin
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

buildbucket: fix instrumentation Make ts mon instrumentation top-level instrumentation TBR=sergeyberezin@chromium.org BUG=604947 Committed: https://chromium.googlesource.com/infra/infra/+/bcf60c35f3573f44eea7f20b8da24f20a0572c49

Patch Set 1 #

Patch Set 2 : disable gae_ts_mon in api_test.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M appengine/cr-buildbucket/api.py View 1 chunk +3 lines, -3 lines 0 comments Download
M appengine/cr-buildbucket/test/api_test.py View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Sergey Berezin
Ah, yes, ts_mon needs to catch other decorator's exceptions... I missed that initially. Thanks, LGTM.
4 years, 8 months ago (2016-04-20 00:24:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903653002/1
4 years, 8 months ago (2016-04-20 00:24:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Infra Linux Trusty 64 Tester on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Linux%20Trusty%2064%20Tester/builds/1548)
4 years, 8 months ago (2016-04-20 00:32:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903653002/20001
4 years, 8 months ago (2016-04-20 15:44:34 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-20 15:52:10 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/bcf60c35f3573f44eea7f20b8da24...

Powered by Google App Engine
This is Rietveld 408576698