Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1903623002: [Mac/GN] Get //ppapi tests and examples working. (Closed)

Created:
4 years, 8 months ago by Robert Sesek
Modified:
4 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-framework-content
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Get //ppapi tests and examples working. BUG=431177 Committed: https://crrev.com/4a73557574b16b4564842a3920202a93ebacfeb0 Cr-Commit-Position: refs/heads/master@{#388372}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -15 lines) Patch
M build/config/mac/rules.gni View 3 chunks +11 lines, -3 lines 0 comments Download
M ppapi/BUILD.gn View 3 chunks +30 lines, -2 lines 0 comments Download
M ppapi/examples/ppapi_example.gni View 1 chunk +24 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Robert Sesek
4 years, 8 months ago (2016-04-19 22:21:58 UTC) #3
brettw
lgtm
4 years, 8 months ago (2016-04-20 00:05:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903623002/20001
4 years, 8 months ago (2016-04-20 00:13:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 8 months ago (2016-04-20 00:18:33 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:18:44 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4a73557574b16b4564842a3920202a93ebacfeb0
Cr-Commit-Position: refs/heads/master@{#388372}

Powered by Google App Engine
This is Rietveld 408576698