Skip canvas filter construction in frameless documents

Skip canvas filter construction in frameless documents

StyleResolver (used for building the font that gets used
during filter construction) and StyleResolverState (used
for filter construction) both currently assume the
existence of a frame.

BUG=603830
Committed: https://crrev.com/68c4df27a19afa05a8743ad653017b009cf79f0d
Cr-Commit-Position: refs/heads/master@{#388587}

[ajuma, 2016-04-19 23:31:31]

Description was changed from

==========
Skip canvas filter construction in frameless documents

BUG=
==========

to

==========
Skip canvas filter construction in frameless documents

StyleResolver (used for building the font that gets used
during filter construction) and StyleResolverState (used
for filter construction) both currently assume the
existence of a frame.

BUG=603830
==========

[ajuma, 2016-04-19 23:32:40]

ajuma@chromium.org changed reviewers:
+ junov@chromium.org

[Justin Novosad, 2016-04-20 18:36:41]

lgtm with nit.

https://codereview.chromium.org/1903613002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-filter-frameless-document-expected.html
(left):

https://codereview.chromium.org/1903613002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-filter-frameless-document-expected.html:1:
This test passes if it doesn't crash.
This test should use testRunner.dumpAsText() instead of being a ref test IMHO.

[ajuma, 2016-04-20 21:09:05]

https://codereview.chromium.org/1903613002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-filter-frameless-document-expected.html
(left):

https://codereview.chromium.org/1903613002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-filter-frameless-document-expected.html:1:
This test passes if it doesn't crash.
On 2016/04/20 18:36:41, Justin Novosad wrote:
> This test should use testRunner.dumpAsText() instead of being a ref test IMHO.

Done.

[ajuma, 2016-04-20 21:09:09]

The CQ bit was checked by ajuma@chromium.org

[ajuma, 2016-04-20 21:09:10]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/1903613002/#ps40001
(title: "Address comment")

[commit-bot: I haz the power, 2016-04-20 21:09:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903613002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903613002/40001

[commit-bot: I haz the power, 2016-04-20 21:21:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 21:21:42]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[ajuma, 2016-04-20 21:28:13]

The CQ bit was checked by ajuma@chromium.org

[commit-bot: I haz the power, 2016-04-20 21:28:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903613002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903613002/40001

[commit-bot: I haz the power, 2016-04-20 23:22:00]

Description was changed from

==========
Skip canvas filter construction in frameless documents

StyleResolver (used for building the font that gets used
during filter construction) and StyleResolverState (used
for filter construction) both currently assume the
existence of a frame.

BUG=603830
==========

to

==========
Skip canvas filter construction in frameless documents

StyleResolver (used for building the font that gets used
during filter construction) and StyleResolverState (used
for filter construction) both currently assume the
existence of a frame.

BUG=603830
==========

[commit-bot: I haz the power, 2016-04-20 23:22:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:26:51]

Description was changed from

==========
Skip canvas filter construction in frameless documents

StyleResolver (used for building the font that gets used
during filter construction) and StyleResolverState (used
for filter construction) both currently assume the
existence of a frame.

BUG=603830
==========

to

==========
Skip canvas filter construction in frameless documents

StyleResolver (used for building the font that gets used
during filter construction) and StyleResolverState (used
for filter construction) both currently assume the
existence of a frame.

BUG=603830

Committed: https://crrev.com/68c4df27a19afa05a8743ad653017b009cf79f0d
Cr-Commit-Position: refs/heads/master@{#388587}
==========

[commit-bot: I haz the power, 2016-04-22 19:26:52]

Patchset 3 (id:??) landed as
https://crrev.com/68c4df27a19afa05a8743ad653017b009cf79f0d
Cr-Commit-Position: refs/heads/master@{#388587}