Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4100)

Unified Diff: chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

Issue 1903593002: Allows to manually change the stored permanent country in Variations from the translate-internals d… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
diff --git a/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc b/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
index d4e8ba932c8829274a000a042e6421a5f27394ec..f885e4db7120f9b01e7230ddb6af146e9e1f9c82 100644
--- a/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
+++ b/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
@@ -10,6 +10,7 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
#include "base/values.h"
+#include "chrome/browser/browser_process.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/translate/chrome_translate_client.h"
@@ -22,6 +23,7 @@
#include "components/translate/core/browser/translate_prefs.h"
#include "components/translate/core/common/language_detection_details.h"
#include "components/translate/core/common/translate_pref_names.h"
+#include "components/variations/service/variations_service.h"
#include "content/public/browser/notification_details.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_source.h"
@@ -60,6 +62,10 @@ void TranslateInternalsHandler::RegisterMessages() {
&TranslateInternalsHandler::OnRemovePrefItem, base::Unretained(this)));
web_ui()->RegisterMessageCallback("requestInfo", base::Bind(
&TranslateInternalsHandler::OnRequestInfo, base::Unretained(this)));
+ web_ui()->RegisterMessageCallback(
+ "overrideCountry",
+ base::Bind(&TranslateInternalsHandler::OnOverrideCountry,
+ base::Unretained(this)));
}
void TranslateInternalsHandler::Observe(
@@ -169,9 +175,22 @@ void TranslateInternalsHandler::OnRemovePrefItem(const base::ListValue* args) {
SendPrefsToJs();
}
+void TranslateInternalsHandler::OnOverrideCountry(const base::ListValue* args) {
+ std::string country;
+ if (args->GetString(0, &country)) {
+ variations::VariationsService* variations_service =
+ g_browser_process->variations_service();
+ if (variations_service) {
+ SendCountryToJs(
+ variations_service->OverrideStoredPermanentCountry(country));
+ }
+ }
+}
+
void TranslateInternalsHandler::OnRequestInfo(const base::ListValue* /*args*/) {
SendPrefsToJs();
SendSupportedLanguagesToJs();
+ SendCountryToJs(false);
}
void TranslateInternalsHandler::SendMessageToJs(const std::string& message,
@@ -232,3 +251,18 @@ void TranslateInternalsHandler::SendSupportedLanguagesToJs() {
new base::FundamentalValue(last_updated.ToJsTime()));
SendMessageToJs("supportedLanguagesUpdated", dict);
}
+
+void TranslateInternalsHandler::SendCountryToJs(bool was_updated) {
+ std::string country;
+ variations::VariationsService* variations_service =
+ g_browser_process->variations_service();
+ if (variations_service)
+ country = variations_service->GetStoredPermanentCountry();
+
+ base::DictionaryValue dict;
+ if (!country.empty()) {
+ dict.Set("country", new base::StringValue(country));
+ dict.Set("update", new base::FundamentalValue(was_updated));
+ }
+ SendMessageToJs("countryUpdated", dict);
+}

Powered by Google App Engine
This is Rietveld 408576698