Allows to manually change the stored permanent country in Variations from the translate-internals d…

chrome/browser/resources/translate_internals/translate_internals.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function() {
   'use strict';
 
   cr.define('cr.translateInternals', function() {
 
     var detectionLogs_ = null;
@@ skipping 235 matching lines @@
         var text = formatLanguageCode(language);
         if (details['alpha_languages'].indexOf(language) != -1)
           text += ' - alpha';
         li.innerText = text;
 
         ul.appendChild(li);
       }
     }
 
     /**
-     * Addes '0's to |number| as a string. |width| is length of the string
+     * Handles the message of 'countryUpdated' from the browser.
+     *
+     * @param {Object} details the object containing the country
+     *     information.
+     */
+    function onCountryUpdated(details) {
+      var p;
+      p = $('country-override');
+
+      p.innerHTML = '';
+
+      if ('country' in details) {
+        var country = details['country'];
+
+        var input = document.createElement('input');
+        input.type = 'text';

[Takashi Toyoshima, 2016/04/22 07:10:08]

Question: Is it safe to allow arbitrary string for this country code replacing?

[Alexei Svitkine (slow), 2016/04/22 14:50:13]

Yep, it's safe. It's just stored in prefs and used in == comparisons to what is
specified in experiment configs. So if you put something strange, it will just
never match.

+        input.value = country;
+
+        var button = document.createElement('button');
+        button.textContent = 'update';
+        button.addEventListener('click', function() {
+          chrome.send('overrideCountry', [input.value]);
+        }, false);
+        p.appendChild(input);
+        p.appendChild(document.createElement('br'));
+        p.appendChild(button);
+
+        if ('update' in details && details['update']) {

[Takashi Toyoshima, 2016/04/22 07:10:08]

IIUC, this configuration isn't directly used by Translate, but used by Finch,
right?

Even so, I'm fine to place this UI here, but probably we need clearer comment
here to describe what this configuration affect. I'm just afraid users and
developers are confused and think this should change Chrome recognizing native
language and foreign language detection.

[Alexei Svitkine (slow), 2016/04/22 14:50:13]

Maybe we can title it something like "Override Variations Country"? With maybe a
tooltip explaining how it's used.

[hamelphi, 2016/04/22 17:20:05]

Added a text explanation about the variable. Alexei, you know more than I do
about the use of this variable. Let me know if you think about more relevant
info to add.

+          var div1 = document.createElement('div');
+          div1.textContent = 'Permanent stored country updated.';
+          var div2 = document.createElement('div');
+          div2.textContent = ('You will need to restart your browser ' +
+              'for the changes to take effect.');
+          p.appendChild(div1);
+          p.appendChild(div2);
+        }
+      } else {
+        p.textContent = 'Could not load country info from Variations.';
+      }
+    }
+
+    /**
+     * Adds '0's to |number| as a string. |width| is length of the string
      * including '0's.
      *
      * @param {string} number The number to be converted into a string.
      * @param {number} width The width of the returned string.
      * @return {string} The formatted string.
      */
     function padWithZeros(number, width) {
       var numberStr = number.toString();
       var restWidth = width - numberStr.length;
       if (restWidth <= 0)
@@ skipping 131 matching lines @@
       switch (message) {
         case 'languageDetectionInfoAdded':
           onLanguageDetectionInfoAdded(details);
           break;
         case 'prefsUpdated':
           onPrefsUpdated(details);
           break;
         case 'supportedLanguagesUpdated':
           onSupportedLanguagesUpdated(details);
           break;
+        case 'countryUpdated':
+          onCountryUpdated(details);
+          break;
         case 'translateErrorDetailsAdded':
           onTranslateErrorDetailsAdded(details);
           break;
         case 'translateEventDetailsAdded':
           onTranslateEventDetailsAdded(details);
           break;
         default:
           console.error('Unknown message:', message);
           break;
       }
@@ skipping 28 matching lines @@
   /**
    * The entry point of the UI.
    */
   function main() {
     cr.doc.addEventListener('DOMContentLoaded',
                             cr.translateInternals.initialize);
   }
 
   main();
 })();