GN Build fixes for Flutter + gen_snapshot fix

GN Build fixes for Flutter + gen_snapshot fix

1. Add "dart_runtime_mode" GN argument. This is an enum with three valid values: "release", "profile", and "develop".
   *) "release" builds product precompiled-runtime.
   *) "profile" builds non-product precompiled-runtime.
   *) "develop" builds non-product non-precompiled-runtime.

2. Remove the redundant "dart_product" GN argument.

3. Kill all *precompiled_runtime static library variants and the related config.

4. Always include the precompiler in gen_snapshot.

5. Support multiple --embedder_entry_points_manifest arguments to gen_snapshot.

6. Update our test harness to use gen_snapshot and pass the same kinds of command line arguments the Flutter folks are using.

7. ASSERT that both DART_PRECOMPILED_RUNTIME and DART_PRECOMPILER are not set at the same time.

R=fschneider@google.com, rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/0cfd4f5cd5a2471a59985e0ccb42712d41e9e892

[Cutch, 2016-04-19 21:13:17]

Description was changed from

==========
Build fixes for Flutter

BUG=
==========

to

==========
GN Build fixes for Flutter + gen_snapshot fix

1. Add "dart_runtime_mode" GN argument. This is an enum with three valid values:
"release", "profile", and "develop".
   *) "release" builds product precompiled-runtime.
   *) "profile" builds non-product precompiled-runtime.
   *) "develop" builds non-product non-precompiled-runtime.

2. Remove the redundant "dart_product" GN argument. 

3. Kill all *precompiled_runtime static library variants and the related config.

4. Only define DART_PRECOMPILER on gen_snapshot.

5. Support multiple --embedder_entry_points_manifest arguments to gen_snapshot.


BUG=
==========

[Cutch, 2016-04-19 21:13:17]

johnmccutchan@google.com changed reviewers:
+ chinmaygarde@google.com, fschneider@google.com, jsimmons@google.com,
rmacnak@google.com

[Florian Schneider, 2016-04-19 21:38:15]

How about a fourth product-non-precompiled variant?

[Cutch, 2016-04-19 21:44:20]

On 2016/04/19 21:38:15, Florian Schneider wrote:
> How about a fourth product-non-precompiled variant?

The variants are coming from Flutter. The exact shape of each variant isn't set
in stone yet. We can play what "release", "profile", and "develop" mean on each
architecture. For example, we might decide that "release" on Android is product
non-precompiled.

[Florian Schneider, 2016-04-19 22:05:24]

Lgtm.

Do we have test coverage of the 'release' build on our buildbot?

https://codereview.chromium.org/1903583002/diff/1/runtime/BUILD.gn
File runtime/BUILD.gn (right):

https://codereview.chromium.org/1903583002/diff/1/runtime/BUILD.gn#newcode56
runtime/BUILD.gn:56: if (dart_runtime_mode == "profile") {
else if

https://codereview.chromium.org/1903583002/diff/1/runtime/bin/gen_snapshot.cc
File runtime/bin/gen_snapshot.cc (right):

https://codereview.chromium.org/1903583002/diff/1/runtime/bin/gen_snapshot.cc...
runtime/bin/gen_snapshot.cc:789: int64_t entry_count = 0;
intptr_t

https://codereview.chromium.org/1903583002/diff/1/runtime/bin/gen_snapshot.cc...
runtime/bin/gen_snapshot.cc:803: int64_t entries =
ParseEntryPointsManifestLines(file, NULL);
intptr_t

https://codereview.chromium.org/1903583002/diff/1/runtime/bin/gen_snapshot.cc...
runtime/bin/gen_snapshot.cc:822: int64_t parsed_entry_count = 0;
intptr_t

https://codereview.chromium.org/1903583002/diff/1/runtime/bin/gen_snapshot.cc...
runtime/bin/gen_snapshot.cc:825: FILE* file = fopen(path, "r");
Check return value of fopen.

[rmacnak, 2016-04-19 23:32:25]

On 2016/04/19 22:05:24, Florian Schneider wrote:
> Lgtm.
> 
> Do we have test coverage of the 'release' build on our buildbot?
> 
> https://codereview.chromium.org/1903583002/diff/1/runtime/BUILD.gn
> File runtime/BUILD.gn (right):
> 
> https://codereview.chromium.org/1903583002/diff/1/runtime/BUILD.gn#newcode56
> runtime/BUILD.gn:56: if (dart_runtime_mode == "profile") {
> else if
> 
> https://codereview.chromium.org/1903583002/diff/1/runtime/bin/gen_snapshot.cc
> File runtime/bin/gen_snapshot.cc (right):
> 
>
https://codereview.chromium.org/1903583002/diff/1/runtime/bin/gen_snapshot.cc...
> runtime/bin/gen_snapshot.cc:789: int64_t entry_count = 0;
> intptr_t
> 
>
https://codereview.chromium.org/1903583002/diff/1/runtime/bin/gen_snapshot.cc...
> runtime/bin/gen_snapshot.cc:803: int64_t entries =
> ParseEntryPointsManifestLines(file, NULL);
> intptr_t
> 
>
https://codereview.chromium.org/1903583002/diff/1/runtime/bin/gen_snapshot.cc...
> runtime/bin/gen_snapshot.cc:822: int64_t parsed_entry_count = 0;
> intptr_t
> 
>
https://codereview.chromium.org/1903583002/diff/1/runtime/bin/gen_snapshot.cc...
> runtime/bin/gen_snapshot.cc:825: FILE* file = fopen(path, "r");
> Check return value of fopen.

When I patched this in, gen_snapshot hit the stubbed out version of
Dart_Precompile(), so the define DART_PRECOMPILER doesn't seem to have made it
through.

[Florian Schneider, 2016-04-20 11:04:37]

On 2016/04/19 23:32:25, rmacnak wrote:
> On 2016/04/19 22:05:24, Florian Schneider wrote:
> > Lgtm.
> > 
> > Do we have test coverage of the 'release' build on our buildbot?
> > 
> > https://codereview.chromium.org/1903583002/diff/1/runtime/BUILD.gn
> > File runtime/BUILD.gn (right):
> > 
> > https://codereview.chromium.org/1903583002/diff/1/runtime/BUILD.gn#newcode56
> > runtime/BUILD.gn:56: if (dart_runtime_mode == "profile") {
> > else if
> > 
> >
https://codereview.chromium.org/1903583002/diff/1/runtime/bin/gen_snapshot.cc
> > File runtime/bin/gen_snapshot.cc (right):
> > 
> >
>
https://codereview.chromium.org/1903583002/diff/1/runtime/bin/gen_snapshot.cc...
> > runtime/bin/gen_snapshot.cc:789: int64_t entry_count = 0;
> > intptr_t
> > 
> >
>
https://codereview.chromium.org/1903583002/diff/1/runtime/bin/gen_snapshot.cc...
> > runtime/bin/gen_snapshot.cc:803: int64_t entries =
> > ParseEntryPointsManifestLines(file, NULL);
> > intptr_t
> > 
> >
>
https://codereview.chromium.org/1903583002/diff/1/runtime/bin/gen_snapshot.cc...
> > runtime/bin/gen_snapshot.cc:822: int64_t parsed_entry_count = 0;
> > intptr_t
> > 
> >
>
https://codereview.chromium.org/1903583002/diff/1/runtime/bin/gen_snapshot.cc...
> > runtime/bin/gen_snapshot.cc:825: FILE* file = fopen(path, "r");
> > Check return value of fopen.
> 
> When I patched this in, gen_snapshot hit the stubbed out version of
> Dart_Precompile(), so the define DART_PRECOMPILER doesn't seem to have made it
> through.

Should we maybe switch to use gen_snapshot instead of dart_bootstrap on our side
as well, so that we test the same configuration?

[Cutch, 2016-04-20 14:55:13]

On 2016/04/19 23:32:25, rmacnak wrote:
> When I patched this in, gen_snapshot hit the stubbed out version of
> Dart_Precompile(), so the define DART_PRECOMPILER doesn't seem to have made it
> through.

Yesterday you said that DART_PRECOMPILER only needs to be set for
gen_snapshot.cc. I just looked at gen_snapshot.cc and it doesn't even check for
DART_PRECOMPILER. Wwhat we need is DART_PRECOMPILER to be set while building
libdart_vm so that the right bits are compiled in compiler.cc, dart_api_impl.cc,
and precompiler.cc. 

A cleaner solution is to use PRODUCT to control whether or not the precompiler
is included. I'm going to update this CL to do that.

[Cutch, 2016-04-20 14:57:13]

On 2016/04/20 11:04:37, Florian Schneider wrote:
> On 2016/04/19 23:32:25, rmacnak wrote:
> > On 2016/04/19 22:05:24, Florian Schneider wrote:
> > > Lgtm.
> > > 
> > > Do we have test coverage of the 'release' build on our buildbot?
> > > 
> > > https://codereview.chromium.org/1903583002/diff/1/runtime/BUILD.gn
> > > File runtime/BUILD.gn (right):
> > > 
> > >
https://codereview.chromium.org/1903583002/diff/1/runtime/BUILD.gn#newcode56
> > > runtime/BUILD.gn:56: if (dart_runtime_mode == "profile") {
> > > else if
> > > 
> > >
> https://codereview.chromium.org/1903583002/diff/1/runtime/bin/gen_snapshot.cc
> > > File runtime/bin/gen_snapshot.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1903583002/diff/1/runtime/bin/gen_snapshot.cc...
> > > runtime/bin/gen_snapshot.cc:789: int64_t entry_count = 0;
> > > intptr_t
> > > 
> > >
> >
>
https://codereview.chromium.org/1903583002/diff/1/runtime/bin/gen_snapshot.cc...
> > > runtime/bin/gen_snapshot.cc:803: int64_t entries =
> > > ParseEntryPointsManifestLines(file, NULL);
> > > intptr_t
> > > 
> > >
> >
>
https://codereview.chromium.org/1903583002/diff/1/runtime/bin/gen_snapshot.cc...
> > > runtime/bin/gen_snapshot.cc:822: int64_t parsed_entry_count = 0;
> > > intptr_t
> > > 
> > >
> >
>
https://codereview.chromium.org/1903583002/diff/1/runtime/bin/gen_snapshot.cc...
> > > runtime/bin/gen_snapshot.cc:825: FILE* file = fopen(path, "r");
> > > Check return value of fopen.
> > 
> > When I patched this in, gen_snapshot hit the stubbed out version of
> > Dart_Precompile(), so the define DART_PRECOMPILER doesn't seem to have made
it
> > through.
> 
> Should we maybe switch to use gen_snapshot instead of dart_bootstrap on our
side
> as well, so that we test the same configuration?

I didn't realize we weren't testing the same tools/workflow as our developers :(
We must be using the same set of tools as our developers.

[Cutch, 2016-04-20 15:56:45]

Description was changed from

==========
GN Build fixes for Flutter + gen_snapshot fix

1. Add "dart_runtime_mode" GN argument. This is an enum with three valid values:
"release", "profile", and "develop".
   *) "release" builds product precompiled-runtime.
   *) "profile" builds non-product precompiled-runtime.
   *) "develop" builds non-product non-precompiled-runtime.

2. Remove the redundant "dart_product" GN argument. 

3. Kill all *precompiled_runtime static library variants and the related config.

4. Only define DART_PRECOMPILER on gen_snapshot.

5. Support multiple --embedder_entry_points_manifest arguments to gen_snapshot.


BUG=
==========

to

==========
GN Build fixes for Flutter + gen_snapshot fix

1. Add "dart_runtime_mode" GN argument. This is an enum with three valid values:
"release", "profile", and "develop".
   *) "release" builds product precompiled-runtime.
   *) "profile" builds non-product precompiled-runtime.
   *) "develop" builds non-product non-precompiled-runtime.

2. Remove the redundant "dart_product" GN argument. 

3. Kill all *precompiled_runtime static library variants and the related config.

4. Replace DART_PRECOMPILER with PRODUCT.

5. Support multiple --embedder_entry_points_manifest arguments to gen_snapshot.


BUG=
==========

[Cutch, 2016-04-20 15:57:26]

PTAL. Only thing left on my TODO for this CL is to switch the VM over to using
gen_snapshot instead of dart_bootstrap.

[rmacnak, 2016-04-20 16:48:17]

On 2016/04/20 14:55:13, Cutch wrote:
> On 2016/04/19 23:32:25, rmacnak wrote:
> > When I patched this in, gen_snapshot hit the stubbed out version of
> > Dart_Precompile(), so the define DART_PRECOMPILER doesn't seem to have made
it
> > through.
> 
> Yesterday you said that DART_PRECOMPILER only needs to be set for
> gen_snapshot.cc. I just looked at gen_snapshot.cc and it doesn't even check
for
> DART_PRECOMPILER. Wwhat we need is DART_PRECOMPILER to be set while building
> libdart_vm so that the right bits are compiled in compiler.cc,
dart_api_impl.cc,
> and precompiler.cc.

Sorry that was unclear. gen_snapshot the binary, not gen_snapshot.cc, needs
DART_PRECOMPILER. 

> A cleaner solution is to use PRODUCT to control whether or not the precompiler
> is included. I'm going to update this CL to do that.

I don't see why PRODUCT is relevant here. Debug and release gen_snapshot need to
be able to precompile as well, and product mode runtimes should exclude it.

[Cutch, 2016-04-20 19:35:30]

Description was changed from

==========
GN Build fixes for Flutter + gen_snapshot fix

1. Add "dart_runtime_mode" GN argument. This is an enum with three valid values:
"release", "profile", and "develop".
   *) "release" builds product precompiled-runtime.
   *) "profile" builds non-product precompiled-runtime.
   *) "develop" builds non-product non-precompiled-runtime.

2. Remove the redundant "dart_product" GN argument. 

3. Kill all *precompiled_runtime static library variants and the related config.

4. Replace DART_PRECOMPILER with PRODUCT.

5. Support multiple --embedder_entry_points_manifest arguments to gen_snapshot.


BUG=
==========

to

==========
GN Build fixes for Flutter + gen_snapshot fix

1. Add "dart_runtime_mode" GN argument. This is an enum with three valid values:
"release", "profile", and "develop".
   *) "release" builds product precompiled-runtime.
   *) "profile" builds non-product precompiled-runtime.
   *) "develop" builds non-product non-precompiled-runtime.

2. Remove the redundant "dart_product" GN argument. 

3. Kill all *precompiled_runtime static library variants and the related config.

4. Add "dart_include_aot_compiler" GN argument. This is a boolean that controls
whether or not the precompiler is included in the build.

5. Support multiple --embedder_entry_points_manifest arguments to gen_snapshot.


BUG=
==========

[Cutch, 2016-04-20 21:18:08]

Description was changed from

==========
GN Build fixes for Flutter + gen_snapshot fix

1. Add "dart_runtime_mode" GN argument. This is an enum with three valid values:
"release", "profile", and "develop".
   *) "release" builds product precompiled-runtime.
   *) "profile" builds non-product precompiled-runtime.
   *) "develop" builds non-product non-precompiled-runtime.

2. Remove the redundant "dart_product" GN argument. 

3. Kill all *precompiled_runtime static library variants and the related config.

4. Add "dart_include_aot_compiler" GN argument. This is a boolean that controls
whether or not the precompiler is included in the build.

5. Support multiple --embedder_entry_points_manifest arguments to gen_snapshot.


BUG=
==========

to

==========
GN Build fixes for Flutter + gen_snapshot fix

1. Add "dart_runtime_mode" GN argument. This is an enum with three valid values:
"release", "profile", and "develop".
   *) "release" builds product precompiled-runtime.
   *) "profile" builds non-product precompiled-runtime.
   *) "develop" builds non-product non-precompiled-runtime.

2. Remove the redundant "dart_product" GN argument. 

3. Kill all *precompiled_runtime static library variants and the related config.

4. Add "dart_include_aot_compiler" GN argument. This is a boolean that controls
whether or not the precompiler is included in the build.

5. Support multiple --embedder_entry_points_manifest arguments to gen_snapshot.

6. Update our test harness to use gen_snapshot and pass the same kinds of
command line arguments the Flutter folks are using.

BUG=
==========

[Cutch, 2016-04-20 21:19:01]

PTAL

[Cutch, 2016-04-20 21:33:14]

Description was changed from

==========
GN Build fixes for Flutter + gen_snapshot fix

1. Add "dart_runtime_mode" GN argument. This is an enum with three valid values:
"release", "profile", and "develop".
   *) "release" builds product precompiled-runtime.
   *) "profile" builds non-product precompiled-runtime.
   *) "develop" builds non-product non-precompiled-runtime.

2. Remove the redundant "dart_product" GN argument. 

3. Kill all *precompiled_runtime static library variants and the related config.

4. Add "dart_include_aot_compiler" GN argument. This is a boolean that controls
whether or not the precompiler is included in the build.

5. Support multiple --embedder_entry_points_manifest arguments to gen_snapshot.

6. Update our test harness to use gen_snapshot and pass the same kinds of
command line arguments the Flutter folks are using.

BUG=
==========

to

==========
GN Build fixes for Flutter + gen_snapshot fix

1. Add "dart_runtime_mode" GN argument. This is an enum with three valid values:
"release", "profile", and "develop".
   *) "release" builds product precompiled-runtime.
   *) "profile" builds non-product precompiled-runtime.
   *) "develop" builds non-product non-precompiled-runtime.

2. Remove the redundant "dart_product" GN argument. 

3. Kill all *precompiled_runtime static library variants and the related config.

4. Add "dart_include_aot_compiler" GN argument. This is a boolean that controls
whether or not the precompiler is included in the build.

5. Support multiple --embedder_entry_points_manifest arguments to gen_snapshot.

6. Update our test harness to use gen_snapshot and pass the same kinds of
command line arguments the Flutter folks are using.


Expected usage:

To generate a precompiled snapshot, build for the host with:

dart_runtime_mode=X dart_include_aot_compiler=true

Use host gen_snapshot to generate the precompiled snapshot.

To run a precompiled snapshot, build for the target with:

dart_runtime_mode=X dart_include_aot_compiler=false
==========

[rmacnak, 2016-04-20 22:56:05]

I'm seeing a bunch of bogus MissingCompileTimeError running

tools/test.py -mrelease -cprecompiler -rdart_precompiled language

presumably gen_snapshot and dart_bootstrap aren't changing the exit code the
same way.

https://chromiumcodereview.appspot.com/1903583002/diff/80001/tools/testing/da...
File tools/testing/dart/compiler_configuration.dart (right):

https://chromiumcodereview.appspot.com/1903583002/diff/80001/tools/testing/da...
tools/testing/dart/compiler_configuration.dart:348:
args.add("--embedder_entry_points_manifest=$dartEntries");
if (!product) {
  args.add("--embedder_entry_points_manifest=$dartEntries");
}

[Cutch, 2016-04-21 15:00:57]

Compilation errors not being reported by tests has been addressed.

https://codereview.chromium.org/1903583002/diff/80001/tools/testing/dart/comp...
File tools/testing/dart/compiler_configuration.dart (right):

https://codereview.chromium.org/1903583002/diff/80001/tools/testing/dart/comp...
tools/testing/dart/compiler_configuration.dart:348:
args.add("--embedder_entry_points_manifest=$dartEntries");
On 2016/04/20 22:56:04, rmacnak wrote:
> if (!product) {
>   args.add("--embedder_entry_points_manifest=$dartEntries");
> }

Done.

[rmacnak, 2016-04-21 16:53:48]

lgtm

[Cutch, 2016-04-21 17:59:24]

Description was changed from

==========
GN Build fixes for Flutter + gen_snapshot fix

1. Add "dart_runtime_mode" GN argument. This is an enum with three valid values:
"release", "profile", and "develop".
   *) "release" builds product precompiled-runtime.
   *) "profile" builds non-product precompiled-runtime.
   *) "develop" builds non-product non-precompiled-runtime.

2. Remove the redundant "dart_product" GN argument. 

3. Kill all *precompiled_runtime static library variants and the related config.

4. Add "dart_include_aot_compiler" GN argument. This is a boolean that controls
whether or not the precompiler is included in the build.

5. Support multiple --embedder_entry_points_manifest arguments to gen_snapshot.

6. Update our test harness to use gen_snapshot and pass the same kinds of
command line arguments the Flutter folks are using.


Expected usage:

To generate a precompiled snapshot, build for the host with:

dart_runtime_mode=X dart_include_aot_compiler=true

Use host gen_snapshot to generate the precompiled snapshot.

To run a precompiled snapshot, build for the target with:

dart_runtime_mode=X dart_include_aot_compiler=false
==========

to

==========
GN Build fixes for Flutter + gen_snapshot fix

1. Add "dart_runtime_mode" GN argument. This is an enum with three valid values:
"release", "profile", and "develop".
   *) "release" builds product precompiled-runtime.
   *) "profile" builds non-product precompiled-runtime.
   *) "develop" builds non-product non-precompiled-runtime.

2. Remove the redundant "dart_product" GN argument. 

3. Kill all *precompiled_runtime static library variants and the related config.

4. Always include the precompiler.

5. Support multiple --embedder_entry_points_manifest arguments to gen_snapshot.

6. Update our test harness to use gen_snapshot and pass the same kinds of
command line arguments the Flutter folks are using.
==========

[Cutch, 2016-04-22 00:47:33]

Description was changed from

==========
GN Build fixes for Flutter + gen_snapshot fix

1. Add "dart_runtime_mode" GN argument. This is an enum with three valid values:
"release", "profile", and "develop".
   *) "release" builds product precompiled-runtime.
   *) "profile" builds non-product precompiled-runtime.
   *) "develop" builds non-product non-precompiled-runtime.

2. Remove the redundant "dart_product" GN argument. 

3. Kill all *precompiled_runtime static library variants and the related config.

4. Always include the precompiler.

5. Support multiple --embedder_entry_points_manifest arguments to gen_snapshot.

6. Update our test harness to use gen_snapshot and pass the same kinds of
command line arguments the Flutter folks are using.
==========

to

==========
GN Build fixes for Flutter + gen_snapshot fix

1. Add "dart_runtime_mode" GN argument. This is an enum with three valid values:
"release", "profile", and "develop".
   *) "release" builds product precompiled-runtime.
   *) "profile" builds non-product precompiled-runtime.
   *) "develop" builds non-product non-precompiled-runtime.

2. Remove the redundant "dart_product" GN argument. 

3. Kill all *precompiled_runtime static library variants and the related config.

4. Always include the precompiler in gen_snapshot.

5. Support multiple --embedder_entry_points_manifest arguments to gen_snapshot.

6. Update our test harness to use gen_snapshot and pass the same kinds of
command line arguments the Flutter folks are using.
==========

[Cutch, 2016-04-22 01:06:52]

Description was changed from

==========
GN Build fixes for Flutter + gen_snapshot fix

1. Add "dart_runtime_mode" GN argument. This is an enum with three valid values:
"release", "profile", and "develop".
   *) "release" builds product precompiled-runtime.
   *) "profile" builds non-product precompiled-runtime.
   *) "develop" builds non-product non-precompiled-runtime.

2. Remove the redundant "dart_product" GN argument. 

3. Kill all *precompiled_runtime static library variants and the related config.

4. Always include the precompiler in gen_snapshot.

5. Support multiple --embedder_entry_points_manifest arguments to gen_snapshot.

6. Update our test harness to use gen_snapshot and pass the same kinds of
command line arguments the Flutter folks are using.
==========

to

==========
GN Build fixes for Flutter + gen_snapshot fix

1. Add "dart_runtime_mode" GN argument. This is an enum with three valid values:
"release", "profile", and "develop".
   *) "release" builds product precompiled-runtime.
   *) "profile" builds non-product precompiled-runtime.
   *) "develop" builds non-product non-precompiled-runtime.

2. Remove the redundant "dart_product" GN argument. 

3. Kill all *precompiled_runtime static library variants and the related config.

4. Always include the precompiler in gen_snapshot.

5. Support multiple --embedder_entry_points_manifest arguments to gen_snapshot.

6. Update our test harness to use gen_snapshot and pass the same kinds of
command line arguments the Flutter folks are using.

7. ASSERT that both DART_PRECOMPILED_RUNTIME and DART_PRECOMPILER are not set at
the same time.
==========

[Cutch, 2016-04-22 01:09:41]

As discussed offline:

- DART_PRECOMPILED_RUNTIME and DART_PRECOMPILER are not set simultaneously.
- DART_PRECOMPILER is always included in 'gen_snapshot'.

In order to do the above, I inverted libfoo and libfoo_precompiled_runtime
configurations. We now have libfoo and libfoo_with_precompiler configurations
but libfoo_with_precompiler is only consumed internally by gen_snapshot.
External uses only ever link with libfoo.

PTAL

[rmacnak, 2016-04-22 02:48:54]

lgtm w/nits

https://codereview.chromium.org/1903583002/diff/180001/runtime/BUILD.gn
File runtime/BUILD.gn (right):

https://codereview.chromium.org/1903583002/diff/180001/runtime/BUILD.gn#newco...
runtime/BUILD.gn:151: configs += [":dart_config", ":dart_product_config",
":dart_precompiled_runtime_config"]
(throughout) long line, split like deps

https://codereview.chromium.org/1903583002/diff/180001/runtime/platform/globa...
File runtime/platform/globals.h (right):

https://codereview.chromium.org/1903583002/diff/180001/runtime/platform/globa...
runtime/platform/globals.h:140: #error DART_PRECOMPILED_RUNTIME and
DART_PRECOMPILER are mutally exclusive
mutually

[Cutch, 2016-04-22 14:00:11]

Description was changed from

==========
GN Build fixes for Flutter + gen_snapshot fix

1. Add "dart_runtime_mode" GN argument. This is an enum with three valid values:
"release", "profile", and "develop".
   *) "release" builds product precompiled-runtime.
   *) "profile" builds non-product precompiled-runtime.
   *) "develop" builds non-product non-precompiled-runtime.

2. Remove the redundant "dart_product" GN argument. 

3. Kill all *precompiled_runtime static library variants and the related config.

4. Always include the precompiler in gen_snapshot.

5. Support multiple --embedder_entry_points_manifest arguments to gen_snapshot.

6. Update our test harness to use gen_snapshot and pass the same kinds of
command line arguments the Flutter folks are using.

7. ASSERT that both DART_PRECOMPILED_RUNTIME and DART_PRECOMPILER are not set at
the same time.
==========

to

==========
GN Build fixes for Flutter + gen_snapshot fix

1. Add "dart_runtime_mode" GN argument. This is an enum with three valid values:
"release", "profile", and "develop".
   *) "release" builds product precompiled-runtime.
   *) "profile" builds non-product precompiled-runtime.
   *) "develop" builds non-product non-precompiled-runtime.

2. Remove the redundant "dart_product" GN argument.

3. Kill all *precompiled_runtime static library variants and the related config.

4. Always include the precompiler in gen_snapshot.

5. Support multiple --embedder_entry_points_manifest arguments to gen_snapshot.

6. Update our test harness to use gen_snapshot and pass the same kinds of
command line arguments the Flutter folks are using.

7. ASSERT that both DART_PRECOMPILED_RUNTIME and DART_PRECOMPILER are not set at
the same time.

R=fschneider@google.com, rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0cfd4f5cd5a2471a59985e0ccb42712d41e9e892
==========

[Cutch, 2016-04-22 14:00:12]

Committed patchset #11 (id:200001) manually as
0cfd4f5cd5a2471a59985e0ccb42712d41e9e892 (presubmit successful).

[Cutch, 2016-04-22 14:05:15]

https://codereview.chromium.org/1903583002/diff/180001/runtime/BUILD.gn
File runtime/BUILD.gn (right):

https://codereview.chromium.org/1903583002/diff/180001/runtime/BUILD.gn#newco...
runtime/BUILD.gn:151: configs += [":dart_config", ":dart_product_config",
":dart_precompiled_runtime_config"]
On 2016/04/22 02:48:54, rmacnak wrote:
> (throughout) long line, split like deps

Done here and elsewhere.

https://codereview.chromium.org/1903583002/diff/180001/runtime/platform/globa...
File runtime/platform/globals.h (right):

https://codereview.chromium.org/1903583002/diff/180001/runtime/platform/globa...
runtime/platform/globals.h:140: #error DART_PRECOMPILED_RUNTIME and
DART_PRECOMPILER are mutally exclusive
On 2016/04/22 02:48:54, rmacnak wrote:
> mutually

Done.