Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1903553002:
Add explicit clip to SkSpecialSurface's SkCanvas (Closed)
|
Created:
4 years, 8 months ago by robertphillips Modified:
4 years, 8 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionAdd explicit clip to SkSpecialSurface's SkCanvas
It seems safer (and is probably more performant) to enforce this internal to SkSpecialSurface.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1903553002
Committed: https://skia.googlesource.com/skia/+/4c13db2a6bb4c795bec6b050b6ebd2ff5177bb5e
Patch Set 1 #Patch Set 2 : Eerrggh #Messages
Total messages: 19 (10 generated)
Description was changed from ========== Add explicit clip to SkSpecialSurface's SkCanvas ========== to ========== Add explicit clip to SkSpecialSurface's SkCanvas GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Add explicit clip to SkSpecialSurface's SkCanvas GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add explicit clip to SkSpecialSurface's SkCanvas It seems safer (and is probably more performant) to enforce this internal to SkSpecialSurface. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
robertphillips@google.com changed reviewers: + bsalomon@google.com
robertphillips@google.com changed reviewers: + reed@google.com
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903553002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903553002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903553002/20001
Message was sent while issue was closed.
Description was changed from ========== Add explicit clip to SkSpecialSurface's SkCanvas It seems safer (and is probably more performant) to enforce this internal to SkSpecialSurface. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add explicit clip to SkSpecialSurface's SkCanvas It seems safer (and is probably more performant) to enforce this internal to SkSpecialSurface. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/4c13db2a6bb4c795bec6b050b6ebd2ff5177bb5e ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/4c13db2a6bb4c795bec6b050b6ebd2ff5177bb5e |
