Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1903533002:
Change FlakyTest from android.test.FlakyTest to our version (Closed)
|
Created:
4 years, 8 months ago by Yoland Yan(Google) Modified:
4 years, 8 months ago CC:
asanka, chromium-reviews, darin-cc_chromium.org, jam Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionChange FlakyTest from android.test.FlakyTest to our version
BUG=
Committed: https://crrev.com/8cb12cd108bae4b563464a20624d7c6d3c3aa4b6
Cr-Commit-Position: refs/heads/master@{#389897}
Patch Set 1 #
Total comments: 1
Patch Set 2 : #Patch Set 3 : Rebase #Patch Set 4 : #
Messages
Total messages: 19 (7 generated)
This is the same change as this CL: 1856273002, but these FlakyTest annotations were added in between the time when I changed all previous FlakyTest annotation and the time the PRESUBMIT checker was committed.
lgtm with 1 comment https://codereview.chromium.org/1903533002/diff/1/chrome/android/javatests/sr... File chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java (right): https://codereview.chromium.org/1903533002/diff/1/chrome/android/javatests/sr... chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java:206: @FlakyTest Change @FlakyTest to... @FlakyTest(message = "crbug/415711")
lgtm but please add a crbug
lgtm
lgtm
lgtm
The CQ bit was checked by yolandyan@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from mikecase@chromium.org, aelias@chromium.org, jbudorick@chromium.org, qinmin@chromium.org Link to the patchset: https://codereview.chromium.org/1903533002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903533002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903533002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by yolandyan@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org, jbudorick@chromium.org, qinmin@chromium.org, mikecase@chromium.org, sievers@chromium.org Link to the patchset: https://codereview.chromium.org/1903533002/#ps60001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903533002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903533002/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Change FlakyTest from android.test.FlakyTest to our version BUG= ========== to ========== Change FlakyTest from android.test.FlakyTest to our version BUG= Committed: https://crrev.com/8cb12cd108bae4b563464a20624d7c6d3c3aa4b6 Cr-Commit-Position: refs/heads/master@{#389897} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/8cb12cd108bae4b563464a20624d7c6d3c3aa4b6 Cr-Commit-Position: refs/heads/master@{#389897} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
