Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1903523004: The display can now create a Vulkan Renderer. (Closed)

Created:
4 years, 8 months ago by David Yen
Modified:
4 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@vulkan_context_surface
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The display can now create a Vulkan Renderer. This CL creates the Vulkan Renderer so we can begin filling out the NOTIMPLEMENTED() calls in VulkanRenderer. R=piman@chromium.org BUG=582654 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/2076faba3d37920de1ce53383cc89ec2ef7217ac Cr-Commit-Position: refs/heads/master@{#388691}

Patch Set 1 #

Patch Set 2 : Export VulkanRenderer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -7 lines) Patch
M cc/output/vulkan_renderer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/display.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.cc View 1 chunk +5 lines, -1 line 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/compositor/vulkan_browser_compositor_output_surface.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/compositor/vulkan_browser_compositor_output_surface.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (8 generated)
David Yen
4 years, 8 months ago (2016-04-20 21:15:12 UTC) #1
piman
lgtm
4 years, 8 months ago (2016-04-20 21:18:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903523004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903523004/20001
4 years, 8 months ago (2016-04-20 23:26:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/216009)
4 years, 8 months ago (2016-04-20 23:41:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903523004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903523004/20001
4 years, 8 months ago (2016-04-21 00:03:59 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/216044)
4 years, 8 months ago (2016-04-21 00:12:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903523004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903523004/20001
4 years, 8 months ago (2016-04-21 03:36:05 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-21 04:20:52 UTC) #15
shrike
On 2016/04/21 04:20:52, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) Just ...
4 years, 8 months ago (2016-04-21 16:37:08 UTC) #16
David Yen
On 2016/04/21 16:37:08, shrike wrote: > On 2016/04/21 04:20:52, commit-bot: I haz the power wrote: ...
4 years, 8 months ago (2016-04-21 17:02:33 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:31:29 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2076faba3d37920de1ce53383cc89ec2ef7217ac
Cr-Commit-Position: refs/heads/master@{#388691}

Powered by Google App Engine
This is Rietveld 408576698