scripts/slave/recipes/chromium.expected/full_chromium_fyi_ChromiumPractice.json - Issue 1903503007: goma: use GOMA_SERVICE_ACCOUNT_JSON_FILE (reland #1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.expected/full_chromium_fyi_ChromiumPractice.json

Issue 1903503007: goma: use GOMA_SERVICE_ACCOUNT_JSON_FILE (reland #1) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_fyi_ChromePracticeFullTester.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_fyi_ChromiumPracticeFullTester.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/full_chromium_fyi_ChromiumPractice.json

diff --git a/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ChromiumPractice.json b/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ChromiumPractice.json

index 742198b9871f695ed98018e36e2171a5fe35c0fb..86f74f63099550d3288ea1e18ac3831cb07e2c84 100644

--- a/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ChromiumPractice.json

+++ b/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ChromiumPractice.json

@@ -244,6 +244,8 @@

"goma",

"--goma-jsonstatus",

"/path/to/tmp/json",

+ "--goma-service-account-json-file",

+ "/creds/service_accounts/service-account-goma-client.json",

"--goma-dir",

"[CACHE]/cipd/goma",

"--",