scripts/slave/recipe_modules/chromium/api.py - Issue 1903503007: goma: use GOMA_SERVICE_ACCOUNT_JSON_FILE (reland #1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 1903503007: goma: use GOMA_SERVICE_ACCOUNT_JSON_FILE (reland #1) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/chromium/api.py

diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py

index cd8ea22c9faafad23d0c0c3236bb5e5a383ef8da..09b8bc9a4171bd4c11ce84325cb95a2904cba442 100644

--- a/scripts/slave/recipe_modules/chromium/api.py

+++ b/scripts/slave/recipe_modules/chromium/api.py

@@ -173,7 +173,11 @@ class ChromiumApi(recipe_api.RecipeApi):

if self.c.compile_py.compiler:

args += ['--compiler', self.c.compile_py.compiler]

if 'goma' in self.c.compile_py.compiler:

- args += ['--goma-jsonstatus', self.m.json.output()]

+ args += [

+ '--goma-jsonstatus', self.m.json.output(),

+ '--goma-service-account-json-file',

+ self.m.goma.service_account_json_path,

+ ]

if out_dir:

args += ['--out-dir', out_dir]

if self.c.compile_py.mode: