Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1903503003: MSE: Remove an unnecessary SourceBufferStreamTest (Closed)

Created:
4 years, 8 months ago by wolenetz
Modified:
4 years, 8 months ago
Reviewers:
chcunningham
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MSE: Remove an unnecessary SourceBufferStreamTest SBSTest.DISABLED_GarbageCollection_WaitingForKeyframe has long been disabled, and with the changes last year to reduce the aggressiveness of Chrome MSE garbage collection, the good portions of this test are redundant with newer tests. BUG=140875 Committed: https://crrev.com/1c5daebf9d76c38e4b353dc9dfdc773b3dc754e2 Cr-Commit-Position: refs/heads/master@{#388335}

Patch Set 1 #

Patch Set 2 : Removes the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M media/filters/source_buffer_stream_unittest.cc View 1 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
wolenetz
Please take a look at both patch sets (PS2 is what I'd like to land): ...
4 years, 8 months ago (2016-04-19 20:49:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903503003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903503003/20001
4 years, 8 months ago (2016-04-19 20:51:54 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-19 22:02:29 UTC) #6
chcunningham
lgtm
4 years, 8 months ago (2016-04-19 22:31:14 UTC) #7
wolenetz
On 2016/04/19 22:31:14, chcunningham wrote: > lgtm Thanks Chris. Per our offline chat, as I ...
4 years, 8 months ago (2016-04-19 22:32:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903503003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903503003/20001
4 years, 8 months ago (2016-04-19 22:32:49 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-19 22:38:25 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:17:20 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1c5daebf9d76c38e4b353dc9dfdc773b3dc754e2
Cr-Commit-Position: refs/heads/master@{#388335}

Powered by Google App Engine
This is Rietveld 408576698