Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 1903493003: Handle very large transforms in ContainerNode::boundingBox (Closed)

Created:
4 years, 8 months ago by eae
Modified:
4 years, 8 months ago
Reviewers:
szager1
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle very large transforms in ContainerNode::boundingBox Change ContainerNode::boundingBox to explicitly check for and handle NaN sizes. Very large matrix and scale transforms may result in a NaN value. BUG=597846 TEST=fast/transforms/focus-on-transformed-node.htm R=szager@chromium.org Committed: https://crrev.com/fa1ff2fb43ff5538f6950be40cd7f3751af22678 Cr-Commit-Position: refs/heads/master@{#388374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
A + third_party/WebKit/LayoutTests/fast/transforms/focus-on-transformed-node.html View 2 chunks +10 lines, -5 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/transforms/focus-on-transformed-node-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
eae
4 years, 8 months ago (2016-04-19 23:00:14 UTC) #1
szager1
lgtm
4 years, 8 months ago (2016-04-20 00:18:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903493003/1
4 years, 8 months ago (2016-04-20 00:20:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 00:25:47 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:18:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa1ff2fb43ff5538f6950be40cd7f3751af22678
Cr-Commit-Position: refs/heads/master@{#388374}

Powered by Google App Engine
This is Rietveld 408576698