Delete unused fNamedFactorySet from SkWriteBuffer

Delete unused fNamedFactorySet from SkWriteBuffer

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1903483002

Committed: https://skia.googlesource.com/skia/+/be991efbd9fe62a26a652b5ec8b8c98eb0fc6591

[msarett, 2016-04-19 13:59:43]

Description was changed from

==========
Delete unused code in SkWriteBuffer

BUG=skia:
==========

to

==========
Delete unused code in SkWriteBuffer

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-04-19 14:02:12]

Description was changed from

==========
Delete unused code in SkWriteBuffer

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Delete unused fNamedFactorySet from SkWriteBuffer

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-04-19 14:02:39]

msarett@google.com changed reviewers:
+ djsollen@google.com, mtklein@google.com, reed@google.com

[mtklein, 2016-04-19 14:06:39]

https://codereview.chromium.org/1903483002/diff/1/src/core/SkPictureFlat.h
File src/core/SkPictureFlat.h (left):

https://codereview.chromium.org/1903483002/diff/1/src/core/SkPictureFlat.h#ol...
src/core/SkPictureFlat.h:290:
buffer.setNamedFactoryRecorder(controller->getNamedFactorySet());
Walk me through how it's unused again?  It looks like we do set it.

[reed1, 2016-04-19 14:07:26]

lgtm

[msarett, 2016-04-19 14:13:29]

https://codereview.chromium.org/1903483002/diff/1/src/core/SkPictureFlat.h
File src/core/SkPictureFlat.h (left):

https://codereview.chromium.org/1903483002/diff/1/src/core/SkPictureFlat.h#ol...
src/core/SkPictureFlat.h:290:
buffer.setNamedFactoryRecorder(controller->getNamedFactorySet());
On 2016/04/19 14:06:39, mtklein wrote:
> Walk me through how it's unused again?  It looks like we do set it.

It's never set on the SkFlatController - so this call to set() always passes in
nullptr.

[mtklein, 2016-04-19 14:18:36]

The CQ bit was checked by mtklein@google.com

[mtklein, 2016-04-19 14:18:37]

lgtm

https://codereview.chromium.org/1903483002/diff/1/src/core/SkPictureFlat.h
File src/core/SkPictureFlat.h (left):

https://codereview.chromium.org/1903483002/diff/1/src/core/SkPictureFlat.h#ol...
src/core/SkPictureFlat.h:290:
buffer.setNamedFactoryRecorder(controller->getNamedFactorySet());
On 2016/04/19 at 14:13:29, msarett wrote:
> On 2016/04/19 14:06:39, mtklein wrote:
> > Walk me through how it's unused again?  It looks like we do set it.
> 
> It's never set on the SkFlatController - so this call to set() always passes
in nullptr.

Ah, brilliant!

[commit-bot: I haz the power, 2016-04-19 14:18:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903483002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903483002/1

[commit-bot: I haz the power, 2016-04-19 14:28:01]

Description was changed from

==========
Delete unused fNamedFactorySet from SkWriteBuffer

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Delete unused fNamedFactorySet from SkWriteBuffer

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/be991efbd9fe62a26a652b5ec8b8c98eb0fc6591
==========

[commit-bot: I haz the power, 2016-04-19 14:28:02]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/be991efbd9fe62a26a652b5ec8b8c98eb0fc6591