Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1903393003: Initialize Material Design in views_examples_with_content_exe (Closed)

Created:
4 years, 8 months ago by tapted
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize Material Design in views_examples_with_content_exe This is required since r386582 requires MaterialDesignController initialization to be explicit. It was fixed for views_examples in r388338 This applies a similar fix for views_content_client which is used by views_examples_with_content_exe Also, add an OWNERS file to ui/views_content_client with tapted@. Probably should have done this when I made it in r272902 but I was too timid. BUG=605126 Committed: https://crrev.com/a23372cb2efd67280e8c7e99fdea0c9f8cf797ba Cr-Commit-Position: refs/heads/master@{#389037}

Patch Set 1 #

Patch Set 2 : add owners whynot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, --1 lines) Patch
A + ui/views_content_client/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/views_content_client/views_content_client_main_parts.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tapted
Hi sky, please take a look
4 years, 8 months ago (2016-04-21 05:11:00 UTC) #3
sky
LGTM
4 years, 8 months ago (2016-04-21 16:22:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903393003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903393003/20001
4 years, 8 months ago (2016-04-22 04:28:31 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-22 06:15:42 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:44:43 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a23372cb2efd67280e8c7e99fdea0c9f8cf797ba
Cr-Commit-Position: refs/heads/master@{#389037}

Powered by Google App Engine
This is Rietveld 408576698