Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1903383004: [Smart Lock] Fix account chooser highlighted item. (Closed)

Created:
4 years, 8 months ago by melandory
Modified:
4 years, 7 months ago
Reviewers:
Bernhard Bauer, gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Fix account chooser highlighted item. Force highlight of the selected item in Account chooser take full dialog length. BUG=605527 Committed: https://crrev.com/834cc31549407a99029595b0025341154a65e67d Cr-Commit-Position: refs/heads/master@{#389750}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/res/layout/account_chooser_dialog_item.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
melandory
PTAL, thanks!
4 years, 8 months ago (2016-04-22 08:45:42 UTC) #1
melandory
PTAL, thanks!
4 years, 8 months ago (2016-04-25 15:35:49 UTC) #3
Bernhard Bauer
So, code-wise this L's GTM, but a screenshot before and after would be nice (on ...
4 years, 8 months ago (2016-04-25 15:43:27 UTC) #5
gone
lgtm. I can see why this would help, but yeah, please add screenshots in the ...
4 years, 8 months ago (2016-04-25 17:19:38 UTC) #6
melandory
On 2016/04/25 17:19:38, dfalcantara wrote: > lgtm. I can see why this would help, but ...
4 years, 8 months ago (2016-04-26 11:04:45 UTC) #7
Bernhard Bauer
LGTM On 2016/04/26 11:04:45, melandory wrote: > On 2016/04/25 17:19:38, dfalcantara wrote: > > lgtm. ...
4 years, 8 months ago (2016-04-26 11:17:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903383004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903383004/1
4 years, 8 months ago (2016-04-26 11:19:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 11:51:25 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/834cc31549407a99029595b0025341154a65e67d Cr-Commit-Position: refs/heads/master@{#389750}
4 years, 8 months ago (2016-04-26 11:52:53 UTC) #13
gone
4 years, 7 months ago (2016-04-26 17:36:23 UTC) #14
Message was sent while issue was closed.
There's also build/android/screenshot.py.

Powered by Google App Engine
This is Rietveld 408576698