[Smart Lock] Fix account chooser highlighted item.

[Smart Lock] Fix account chooser highlighted item.

Force highlight of the selected item in Account chooser
take full dialog length.

BUG=605527
Committed: https://crrev.com/834cc31549407a99029595b0025341154a65e67d
Cr-Commit-Position: refs/heads/master@{#389750}

[melandory, 2016-04-22 08:45:42]

PTAL, thanks!

[melandory, 2016-04-25 15:35:49]

melandory@chromium.org changed reviewers:
+ bauerb@chromium.org

[melandory, 2016-04-25 15:35:49]

PTAL, thanks!

[Bernhard Bauer, 2016-04-25 15:43:27]

bauerb@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Bernhard Bauer, 2016-04-25 15:43:27]

So, code-wise this L's GTM, but a screenshot before and after would be nice (on
a publicly visible host, if possible, as nothing in here seems confidential).

Also, I'm only an OWNER for NTP resources, which this isn't, so +Dan to double
check.

[gone, 2016-04-25 17:19:38]

lgtm.  I can see why this would help, but yeah, please add screenshots in the
future.

[melandory, 2016-04-26 11:04:45]

On 2016/04/25 17:19:38, dfalcantara wrote:
> lgtm.  I can see why this would help, but yeah, please add screenshots in the
> future.

I've added screenshots to the bug. Sorry that haven't done it early. Apparently
I can't take them from phones, where buttons are on same side of the phone (it's
too tricky for me to select item in dialog and press those 2 buttons having only
two hands).

BTW, is there other recommended ways to take screenshots except physical buttons
on the phone?

[Bernhard Bauer, 2016-04-26 11:17:02]

LGTM

On 2016/04/26 11:04:45, melandory wrote:
> On 2016/04/25 17:19:38, dfalcantara wrote:
> > lgtm.  I can see why this would help, but yeah, please add screenshots in
the
> > future.
> 
> I've added screenshots to the bug.

Thanks, definitely an improvement!

>  Sorry that haven't done it early. Apparently
> I can't take them from phones, where buttons are on same side of the phone
(it's
> too tricky for me to select item in dialog and press those 2 buttons having
only
> two hands).
> 
> BTW, is there other recommended ways to take screenshots except physical
buttons
> on the phone?

`adb shell screencap`? See
http://blog.shvetsov.com/2013/02/grab-android-screenshot-to-computer-via.html.
If you're using Eclipse, it can also take a screenshot directly from the host.

[melandory, 2016-04-26 11:18:58]

The CQ bit was checked by melandory@chromium.org

[commit-bot: I haz the power, 2016-04-26 11:19:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903383004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903383004/1

[commit-bot: I haz the power, 2016-04-26 11:51:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-26 11:52:52]

Description was changed from

==========
[Smart Lock] Fix account chooser highlighted item.

Force highlight of the selected item in Account chooser
take full dialog length.

BUG=605527
==========

to

==========
[Smart Lock] Fix account chooser highlighted item.

Force highlight of the selected item in Account chooser
take full dialog length.

BUG=605527

Committed: https://crrev.com/834cc31549407a99029595b0025341154a65e67d
Cr-Commit-Position: refs/heads/master@{#389750}
==========

[commit-bot: I haz the power, 2016-04-26 11:52:53]

Patchset 1 (id:??) landed as
https://crrev.com/834cc31549407a99029595b0025341154a65e67d
Cr-Commit-Position: refs/heads/master@{#389750}

[gone, 2016-04-26 17:36:23]

There's also build/android/screenshot.py.