PPC: [turbofan] CodeGenerator: Frame setup refactoring

PPC: [turbofan] CodeGenerator: Frame setup refactoring

Port 81a1530e6fb3f4382098f71c01ffe047ffd72afc

Original commit message:

    Before frame elision, we finalized the frame shape when assembling the
    prologue, which is also when we prepared the frame (saving sp, etc).

    The frame finalization only needs to happen once, and happens to be
    actually a set of idempotent operations. With frame elision, the logic for
    frame finalization was happening every time we constructed the frame.
    Albeit idempotent operations, the code would become hard to maintain.

    This change separates frame shape finalization from frame
    construction. When constructing the CodeGenerator, we finalize the
    frame. Subsequent access is to a const Frame*.

    Also renamed AssemblePrologue to AssembleConstructFrame, as
    suggested in the frame elision CR.

    Separating frame setup gave the opportunity to do away with
    architecture-independent frame aligning (which is something just arm64
    cares about), and also with stack pointer setup (also arm64). Both of
    these happen now at frame finalization on arm64.

R=mtrofin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com

BUG=
LOG=N

Committed: https://crrev.com/a9cb48bf37fe325a54ca010e0760237ed714ab9d
Cr-Commit-Position: refs/heads/master@{#35674}

[JaideepBajwa, 2016-04-20 17:37:11]

PTAL

[MTBrandyberry, 2016-04-20 17:47:38]

https://codereview.chromium.org/1903343002/diff/1/src/compiler/ppc/code-gener...
File src/compiler/ppc/code-generator-ppc.cc (right):

https://codereview.chromium.org/1903343002/diff/1/src/compiler/ppc/code-gener...
src/compiler/ppc/code-generator-ppc.cc:1762: __ MultiPushDoubles(double_saves);
Don't think we want to push here.

https://codereview.chromium.org/1903343002/diff/1/src/compiler/ppc/code-gener...
src/compiler/ppc/code-generator-ppc.cc:1774: __ MultiPush(saves);
Ditto.

[MTBrandyberry, 2016-04-20 18:01:14]

lgtm

[JaideepBajwa, 2016-04-20 18:01:59]

The CQ bit was checked by bjaideep@ca.ibm.com

[commit-bot: I haz the power, 2016-04-20 18:02:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903343002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903343002/20001

[commit-bot: I haz the power, 2016-04-20 18:20:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:13:42]

Description was changed from

==========
PPC: [turbofan] CodeGenerator: Frame setup refactoring

Port 81a1530e6fb3f4382098f71c01ffe047ffd72afc

Original commit message:

    Before frame elision, we finalized the frame shape when assembling the
    prologue, which is also when we prepared the frame (saving sp, etc).

    The frame finalization only needs to happen once, and happens to be
    actually a set of idempotent operations. With frame elision, the logic for
    frame finalization was happening every time we constructed the frame.
    Albeit idempotent operations, the code would become hard to maintain.

    This change separates frame shape finalization from frame
    construction. When constructing the CodeGenerator, we finalize the
    frame. Subsequent access is to a const Frame*.

    Also renamed AssemblePrologue to AssembleConstructFrame, as
    suggested in the frame elision CR.

    Separating frame setup gave the opportunity to do away with
    architecture-independent frame aligning (which is something just arm64
    cares about), and also with stack pointer setup (also arm64). Both of
    these happen now at frame finalization on arm64.

R=mtrofin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com,
michael_dawson@ca.ibm.com, mbrandy@us.ibm.com

BUG=
LOG=N
==========

to

==========
PPC: [turbofan] CodeGenerator: Frame setup refactoring

Port 81a1530e6fb3f4382098f71c01ffe047ffd72afc

Original commit message:

    Before frame elision, we finalized the frame shape when assembling the
    prologue, which is also when we prepared the frame (saving sp, etc).

    The frame finalization only needs to happen once, and happens to be
    actually a set of idempotent operations. With frame elision, the logic for
    frame finalization was happening every time we constructed the frame.
    Albeit idempotent operations, the code would become hard to maintain.

    This change separates frame shape finalization from frame
    construction. When constructing the CodeGenerator, we finalize the
    frame. Subsequent access is to a const Frame*.

    Also renamed AssemblePrologue to AssembleConstructFrame, as
    suggested in the frame elision CR.

    Separating frame setup gave the opportunity to do away with
    architecture-independent frame aligning (which is something just arm64
    cares about), and also with stack pointer setup (also arm64). Both of
    these happen now at frame finalization on arm64.

R=mtrofin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com,
michael_dawson@ca.ibm.com, mbrandy@us.ibm.com

BUG=
LOG=N

Committed: https://crrev.com/a9cb48bf37fe325a54ca010e0760237ed714ab9d
Cr-Commit-Position: refs/heads/master@{#35674}
==========

[commit-bot: I haz the power, 2016-04-22 19:13:43]

Patchset 2 (id:??) landed as
https://crrev.com/a9cb48bf37fe325a54ca010e0760237ed714ab9d
Cr-Commit-Position: refs/heads/master@{#35674}