extensions/renderer/resources/messaging.js - Issue 1903303002: Ensure that privates are private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/messaging.js

Issue 1903303002: Ensure that privates are private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase for safe_builtins conflict Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/resources/messaging.js

diff --git a/extensions/renderer/resources/messaging.js b/extensions/renderer/resources/messaging.js

index 3b98432f887000fbfeba505e28bf17c28645c300..afd7244ece88740bcf69b6bc8820fb28b5b91724 100644

--- a/extensions/renderer/resources/messaging.js

+++ b/extensions/renderer/resources/messaging.js

@@ -400,15 +400,20 @@

return alignedArgs;

}

-var Port = utils.expose('Port', PortImpl, { functions: [

- 'disconnect',

- 'postMessage'

- ],

- properties: [

- 'name',

- 'onDisconnect',

- 'onMessage'

- ] });

+ function Port() {

+ privates(Port).constructPrivate(this, arguments);

+ }

+ utils.expose(Port, PortImpl, {

+ functions: [

+ 'disconnect',

+ 'postMessage',

+ ],

+ properties: [

+ 'name',

+ 'onDisconnect',

+ 'onMessage',

+ ],

+ });

exports.$set('kRequestChannel', kRequestChannel);

exports.$set('kMessageChannel', kMessageChannel);