extensions/renderer/module_system.cc - Issue 1903303002: Ensure that privates are private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/module_system.cc

Issue 1903303002: Ensure that privates are private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase for safe_builtins conflict Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/module_system.cc

diff --git a/extensions/renderer/module_system.cc b/extensions/renderer/module_system.cc

index 9f708bf3eac2cc04c19cba6b6b299a58c3f504ef..dd13786f198f9267b084caa0b810259205ef1e0e 100644

--- a/extensions/renderer/module_system.cc

+++ b/extensions/renderer/module_system.cc

@@ -618,6 +618,10 @@ void ModuleSystem::Private(const v8::FunctionCallbackInfo<v8::Value>& args) {

ToV8StringUnsafe(GetIsolate(), "Failed to create privates"));

return;

}

+ v8::Maybe<bool> maybe =

+ privates.As<v8::Object>()->SetPrototype(context()->v8_context(),

+ v8::Null(args.GetIsolate()));

+ CHECK(maybe.IsJust() && maybe.FromJust());

SetPrivate(obj, "privates", privates);

}

args.GetReturnValue().Set(privates);