extensions/renderer/module_system_unittest.cc - Issue 1903303002: Ensure that privates are private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/module_system_unittest.cc

Issue 1903303002: Ensure that privates are private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix utils.expose Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/module_system_unittest.cc

diff --git a/extensions/renderer/module_system_unittest.cc b/extensions/renderer/module_system_unittest.cc

index f49b3b97a419dfa5e455417e602dfe5e2d4e6004..5803ad0d694cb6bef51b844659486acb785f5ae8 100644

--- a/extensions/renderer/module_system_unittest.cc

+++ b/extensions/renderer/module_system_unittest.cc

@@ -505,4 +505,14 @@ TEST_F(ModuleSystemTest, TestRequireAsyncFromContextWithNoModuleSystem) {

RunResolvedPromises();

}

+TEST_F(ModuleSystemTest, TestPrivatesIsPrivate) {

+ ModuleSystem::NativesEnabledScope natives_enabled_scope(

+ env()->module_system());

+ env()->RegisterModule(

+ "test",

+ "var v = privates({});"

+ "requireNative('assert').AssertFalse(v instanceof Object);");

+ env()->module_system()->Require("test");

} // namespace extensions