chrome/renderer/resources/extensions/enterprise_platform_keys/key_pair.js - Issue 1903303002: Ensure that privates are private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/enterprise_platform_keys/key_pair.js

Issue 1903303002: Ensure that privates are private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix utils.expose Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/resources/extensions/automation/automation_event.js ('K') | « chrome/renderer/resources/extensions/automation/automation_node.js ('k') | chrome/renderer/resources/extensions/enterprise_platform_keys/subtle_crypto.js » ('j') | extensions/renderer/resources/utils.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/enterprise_platform_keys/key_pair.js

diff --git a/chrome/renderer/resources/extensions/enterprise_platform_keys/key_pair.js b/chrome/renderer/resources/extensions/enterprise_platform_keys/key_pair.js

index dc06f16498ddb53cc8a090af60275f7a59758d72..97e4df341ed58745b7f4c25ce0116fd77d4dee60 100644

--- a/chrome/renderer/resources/extensions/enterprise_platform_keys/key_pair.js

+++ b/chrome/renderer/resources/extensions/enterprise_platform_keys/key_pair.js

@@ -30,6 +30,15 @@ var KeyPairImpl = function(publicKeySpki, algorithm, usages) {

false /* not extractable */);

};

-exports.KeyPair = utils.expose('KeyPair',

- KeyPairImpl,

- {readonly:['publicKey', 'privateKey']});

+function KeyPair() {

+ privates(KeyPair).constructPrivate(this, arguments);

+utils.expose(KeyPair, KeyPairImpl, {

+ __proto__: null,

+ readonly: [

+ 'publicKey',

+ 'privateKey',

+ ],

+});

+exports.$set('KeyPair', KeyPair);