extensions/renderer/safe_builtins.cc - Issue 1903303002: Ensure that privates are private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/safe_builtins.cc

Issue 1903303002: Ensure that privates are private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix for failing tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/safe_builtins.cc

diff --git a/extensions/renderer/safe_builtins.cc b/extensions/renderer/safe_builtins.cc

index 1b87bc74272072c5d3f349f62a138c03e0f3511f..f86d92f8583802ce0113820e25168b93eb9d36b9 100644

--- a/extensions/renderer/safe_builtins.cc

+++ b/extensions/renderer/safe_builtins.cc

@@ -71,7 +71,7 @@ const char kScript[] =

" ['hasOwnProperty'],\n"

" ['create', 'defineProperty', 'freeze',\n"

" 'getOwnPropertyDescriptor', 'getPrototypeOf', 'keys',\n"

- " 'assign']);\n"

+ " 'assign', 'setPrototypeOf']);\n"

"saveBuiltin(Function,\n"

" ['apply', 'bind', 'call']);\n"

"saveBuiltin(Array,\n"