chrome/renderer/resources/extensions/platform_keys/subtle_crypto.js - Issue 1903303002: Ensure that privates are private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/platform_keys/subtle_crypto.js

Issue 1903303002: Ensure that privates are private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix for failing tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/platform_keys/key.js ('k') | chrome/renderer/resources/extensions/web_view/chrome_web_view.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/platform_keys/subtle_crypto.js

diff --git a/chrome/renderer/resources/extensions/platform_keys/subtle_crypto.js b/chrome/renderer/resources/extensions/platform_keys/subtle_crypto.js

index 14a5388cef3ad8f189b8b05287e0b8da9c79f6c9..390400394539e665ca5a4e7f5b526711f09d1f20 100644

--- a/chrome/renderer/resources/extensions/platform_keys/subtle_crypto.js

+++ b/chrome/renderer/resources/extensions/platform_keys/subtle_crypto.js

@@ -110,10 +110,16 @@ SubtleCryptoImpl.prototype.exportKey = function(format, key) {

});

};

-// Required for subclassing.

-exports.SubtleCryptoImpl = SubtleCryptoImpl

+function SubtleCrypto() {

+ privates(SubtleCrypto).constructPrivate(this, arguments);

+utils.expose(SubtleCrypto, SubtleCryptoImpl, {

+ functions: [

+ 'sign',

+ 'exportKey',

+ ],

+});

-exports.SubtleCrypto =

- utils.expose('SubtleCrypto',

- SubtleCryptoImpl,

- {functions:['sign', 'exportKey']});

+// Required for subclassing.

+exports.$set('SubtleCryptoImpl', SubtleCryptoImpl);

+exports.$set('SubtleCrypto', SubtleCrypto);