Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1971)

Issue 1903293002: Revert of [wasm] Also test structured stack trace (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@wasm-throw-error
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Also test structured stack trace (patchset #4 id:60001 of https://codereview.chromium.org/1875153002/ ) Reason for revert: Breaks: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20custom%20snapshot%20-%20debug/builds/6322 Original issue's description: > [wasm] Also test structured stack trace > > This extends the wasm test case which only checks the "simple" > string-variant of the stack trace. > It checks the return values of the getFunctionName, getLineNumber, > getFileName and toString methods. > > R=ahaas@chromium.org, jfb@chromium.org, titzer@chromium.org > BUG= TBR=ahaas@chromium.org,jfb@chromium.org,titzer@chromium.org,clemensh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/921381bc1329595d8f51aef99f8331045b5ef0cd Cr-Commit-Position: refs/heads/master@{#35670}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -60 lines) Patch
M test/mjsunit/mjsunit.js View 2 chunks +0 lines, -9 lines 0 comments Download
M test/mjsunit/wasm/stack.js View 2 chunks +15 lines, -51 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Achenbach
Created Revert of [wasm] Also test structured stack trace
4 years, 8 months ago (2016-04-20 16:23:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903293002/1
4 years, 8 months ago (2016-04-20 16:23:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 16:23:32 UTC) #4
Clemens Hammacher
On 2016/04/20 at 16:23:32, commit-bot wrote: > Committed patchset #1 (id:1) Any insight why it ...
4 years, 8 months ago (2016-04-20 16:25:32 UTC) #5
Clemens Hammacher
On 2016/04/20 at 16:25:32, Clemens Hammacher wrote: > On 2016/04/20 at 16:23:32, commit-bot wrote: > ...
4 years, 8 months ago (2016-04-21 07:04:11 UTC) #6
Clemens Hammacher
On 2016/04/21 at 07:04:11, Clemens Hammacher wrote: > OK, it seems that at least one ...
4 years, 8 months ago (2016-04-21 07:45:41 UTC) #7
nodir1
4 years, 8 months ago (2016-04-22 18:44:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/921381bc1329595d8f51aef99f8331045b5ef0cd
Cr-Commit-Position: refs/heads/master@{#35670}

Powered by Google App Engine
This is Rietveld 408576698