Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1169)

Unified Diff: src/runtime-profiler.cc

Issue 1903273004: [compiler] Add baseline tier to compilation pipeline. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime-profiler.h ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime-profiler.cc
diff --git a/src/runtime-profiler.cc b/src/runtime-profiler.cc
index b76785deeb7c7b67a05b0fdae8e3228d77a47e8e..6c9de86ef309dfe96771e2d61fca33d74b7f82d3 100644
--- a/src/runtime-profiler.cc
+++ b/src/runtime-profiler.cc
@@ -106,7 +106,11 @@ void RuntimeProfiler::Optimize(JSFunction* function, const char* reason) {
PrintF("]\n");
}
- function->AttemptConcurrentOptimization();
+ if (function->shared()->HasBytecodeArray()) {
+ function->MarkForBaseline();
+ } else {
+ function->AttemptConcurrentOptimization();
+ }
}
@@ -247,7 +251,8 @@ void RuntimeProfiler::MaybeOptimizeIgnition(JSFunction* function,
// TODO(rmcilroy): Consider whether we should optimize small functions when
// they are first seen on the stack (e.g., kMaxSizeEarlyOpt).
- if (!frame_optimized && (function->IsMarkedForOptimization() ||
+ if (!frame_optimized && (function->IsMarkedForBaseline() ||
+ function->IsMarkedForOptimization() ||
function->IsMarkedForConcurrentOptimization() ||
function->IsOptimized())) {
// TODO(rmcilroy): Support OSR in these cases.
@@ -320,7 +325,7 @@ void RuntimeProfiler::MarkCandidatesForOptimization() {
}
}
- if (FLAG_ignition) {
+ if (frame->is_interpreted()) {
MaybeOptimizeIgnition(function, frame->is_optimized());
} else {
MaybeOptimizeFullCodegen(function, frame_count, frame->is_optimized());
« no previous file with comments | « src/runtime-profiler.h ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698