[Extensions] Sprinkle in some more null protos and defineProperty's

[Extensions] Sprinkle in some more null protos and defineProperty's

BUG=591164
BUG=604901
Committed: https://crrev.com/fda8f6e80af3e5c08905624f356a75b05d27dd39
Cr-Commit-Position: refs/heads/master@{#388994}

[Devlin, 2016-04-21 00:50:55]

Description was changed from

==========
[Extensions] Sprinkle in some more null protos and defineProperty's

BUG=591164
==========

to

==========
[Extensions] Sprinkle in some more null protos and defineProperty's

BUG=591164
BUG=604901
==========

[Devlin, 2016-04-21 02:02:55]

rdevlin.cronin@chromium.org changed reviewers:
+ asargent@chromium.org

[robwu, 2016-04-21 10:29:33]

rob@robwu.nl changed reviewers:
+ rob@robwu.nl

[robwu, 2016-04-21 10:29:33]

https://codereview.chromium.org/1903273003/diff/1/extensions/renderer/resourc...
File extensions/renderer/resources/binding.js (right):

https://codereview.chromium.org/1903273003/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/binding.js:30: this.unavailableApiFunctions_ = {
__proto: null };
Typo: __proto -> __proto__.

https://codereview.chromium.org/1903273003/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/binding.js:191: $Object.defineProperty(Binding,
'create', {
Also use __proto__: null in the property descriptor if you want to make sure
that this call doesn't throw. E.g. if a script does the following before
activating extension bindings, then defineProperty would throw:

Object.prototype.get = 'anything';

https://codereview.chromium.org/1903273003/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/binding.js:386: var apiFunction = { __proto__:
null };
With this change, the separate apiFunctionName variable is not needed any more,
so consider using apiFunction.name again to improve readability.

[Devlin, 2016-04-21 18:28:30]

https://codereview.chromium.org/1903273003/diff/1/extensions/renderer/resourc...
File extensions/renderer/resources/binding.js (right):

https://codereview.chromium.org/1903273003/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/binding.js:30: this.unavailableApiFunctions_ = {
__proto: null };
On 2016/04/21 10:29:33, robwu wrote:
> Typo: __proto -> __proto__.

D'oh, done.

https://codereview.chromium.org/1903273003/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/binding.js:191: $Object.defineProperty(Binding,
'create', {
On 2016/04/21 10:29:33, robwu wrote:
> Also use __proto__: null in the property descriptor if you want to make sure
> that this call doesn't throw. E.g. if a script does the following before
> activating extension bindings, then defineProperty would throw:
> 
> Object.prototype.get = 'anything';

I'm not as worried about avoiding throwing at the moment (it's actually pretty
trivial to make bindings throw - if anything is already defined on the object
prototype, we throw at line 377, so doing
Object.defineProperty(Object.prototype, 'connect', ...) would do it).

But, one line change - worth it.  Done.

https://codereview.chromium.org/1903273003/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/binding.js:386: var apiFunction = { __proto__:
null };
On 2016/04/21 10:29:33, robwu wrote:
> With this change, the separate apiFunctionName variable is not needed any
more,
> so consider using apiFunction.name again to improve readability.

Done.

[asargent_no_longer_on_chrome, 2016-04-21 22:14:13]

lgtm

[Devlin, 2016-04-22 00:30:16]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-04-22 00:30:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903273003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903273003/20001

[commit-bot: I haz the power, 2016-04-22 01:17:46]

Description was changed from

==========
[Extensions] Sprinkle in some more null protos and defineProperty's

BUG=591164
BUG=604901
==========

to

==========
[Extensions] Sprinkle in some more null protos and defineProperty's

BUG=591164
BUG=604901
==========

[commit-bot: I haz the power, 2016-04-22 01:17:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:43:11]

Description was changed from

==========
[Extensions] Sprinkle in some more null protos and defineProperty's

BUG=591164
BUG=604901
==========

to

==========
[Extensions] Sprinkle in some more null protos and defineProperty's

BUG=591164
BUG=604901

Committed: https://crrev.com/fda8f6e80af3e5c08905624f356a75b05d27dd39
Cr-Commit-Position: refs/heads/master@{#388994}
==========

[commit-bot: I haz the power, 2016-04-22 19:43:12]

Patchset 2 (id:??) landed as
https://crrev.com/fda8f6e80af3e5c08905624f356a75b05d27dd39
Cr-Commit-Position: refs/heads/master@{#388994}