Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1903233002: gyp: add osmesa target to factor out common code (Closed)

Created:
4 years, 8 months ago by hal.canary
Modified:
4 years, 8 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

gyp: add osmesa target to factor out common code Test this out with `GYP_DEFINES=skia_mesa=1`. Also uses the `library_dirs` keyword, which is relatively new. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1903233002 Committed: https://skia.googlesource.com/skia/+/906021334fcf45e97670f877ea6f41bb2bc3b060

Patch Set 1 : 2016-04-20 (Wednesday) 10:35:53 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -28 lines) Patch
M gyp/gputest.gyp View 2 chunks +14 lines, -17 lines 0 comments Download
M gyp/tools.gyp View 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903233002/1
4 years, 8 months ago (2016-04-20 14:24:57 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903233002/20001
4 years, 8 months ago (2016-04-20 14:51:19 UTC) #7
hal.canary
PTAL
4 years, 8 months ago (2016-04-20 14:51:42 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-20 15:00:11 UTC) #11
jcgregorio
LGTM for FIDDLE_BUILD_TEST, but really should have someone more familiar with gyp take a look.
4 years, 8 months ago (2016-04-20 15:09:08 UTC) #12
hal.canary
You know gyp as well as anyone. Any objection to this?
4 years, 8 months ago (2016-04-20 15:17:23 UTC) #14
mtklein
no, this very lgtm
4 years, 8 months ago (2016-04-20 15:48:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903233002/20001
4 years, 8 months ago (2016-04-20 15:48:59 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-20 15:49:56 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/906021334fcf45e97670f877ea6f41bb2bc3b060

Powered by Google App Engine
This is Rietveld 408576698