Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Side by Side Diff: src/full-codegen/full-codegen.cc

Issue 1903223003: [debugger,interpreter] fix source position of compare operation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/full-codegen/full-codegen.h" 5 #include "src/full-codegen/full-codegen.h"
6 6
7 #include "src/ast/ast-numbering.h" 7 #include "src/ast/ast-numbering.h"
8 #include "src/ast/ast.h" 8 #include "src/ast/ast.h"
9 #include "src/ast/prettyprinter.h" 9 #include "src/ast/prettyprinter.h"
10 #include "src/ast/scopeinfo.h" 10 #include "src/ast/scopeinfo.h"
(...skipping 1728 matching lines...) Expand 10 before | Expand all | Expand 10 after
1739 void FullCodeGenerator::DeferredCommands::EmitJumpToFinally(TokenId token) { 1739 void FullCodeGenerator::DeferredCommands::EmitJumpToFinally(TokenId token) {
1740 __ Push(Smi::FromInt(token)); 1740 __ Push(Smi::FromInt(token));
1741 __ Push(result_register()); 1741 __ Push(result_register());
1742 __ jmp(finally_entry_); 1742 __ jmp(finally_entry_);
1743 } 1743 }
1744 1744
1745 bool FullCodeGenerator::TryLiteralCompare(CompareOperation* expr) { 1745 bool FullCodeGenerator::TryLiteralCompare(CompareOperation* expr) {
1746 Expression* sub_expr; 1746 Expression* sub_expr;
1747 Handle<String> check; 1747 Handle<String> check;
1748 if (expr->IsLiteralCompareTypeof(&sub_expr, &check)) { 1748 if (expr->IsLiteralCompareTypeof(&sub_expr, &check)) {
1749 SetExpressionPosition(expr);
1749 EmitLiteralCompareTypeof(expr, sub_expr, check); 1750 EmitLiteralCompareTypeof(expr, sub_expr, check);
1750 return true; 1751 return true;
1751 } 1752 }
1752 1753
1753 if (expr->IsLiteralCompareUndefined(&sub_expr)) { 1754 if (expr->IsLiteralCompareUndefined(&sub_expr)) {
1755 SetExpressionPosition(expr);
1754 EmitLiteralCompareNil(expr, sub_expr, kUndefinedValue); 1756 EmitLiteralCompareNil(expr, sub_expr, kUndefinedValue);
1755 return true; 1757 return true;
1756 } 1758 }
1757 1759
1758 if (expr->IsLiteralCompareNull(&sub_expr)) { 1760 if (expr->IsLiteralCompareNull(&sub_expr)) {
1761 SetExpressionPosition(expr);
1759 EmitLiteralCompareNil(expr, sub_expr, kNullValue); 1762 EmitLiteralCompareNil(expr, sub_expr, kNullValue);
1760 return true; 1763 return true;
1761 } 1764 }
1762 1765
1763 return false; 1766 return false;
1764 } 1767 }
1765 1768
1766 1769
1767 void BackEdgeTable::Patch(Isolate* isolate, Code* unoptimized) { 1770 void BackEdgeTable::Patch(Isolate* isolate, Code* unoptimized) {
1768 DisallowHeapAllocation no_gc; 1771 DisallowHeapAllocation no_gc;
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
1937 return var->scope()->is_nonlinear() || 1940 return var->scope()->is_nonlinear() ||
1938 var->initializer_position() >= proxy->position(); 1941 var->initializer_position() >= proxy->position();
1939 } 1942 }
1940 1943
1941 1944
1942 #undef __ 1945 #undef __
1943 1946
1944 1947
1945 } // namespace internal 1948 } // namespace internal
1946 } // namespace v8 1949 } // namespace v8
OLDNEW
« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698