Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1903223003: [debugger,interpreter] fix source position of compare operation. (Closed)

Created:
4 years, 8 months ago by Yang
Modified:
4 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger,interpreter] fix source position of compare operation. R=mstarzinger@chromium.org BUG=v8:4690 LOG=N Committed: https://crrev.com/4b580cad0cc28c498aa3b7fe9ab8c991775b966f Cr-Commit-Position: refs/heads/master@{#35729}

Patch Set 1 #

Patch Set 2 : fix fullcodegen instead #

Patch Set 3 : ports #

Patch Set 4 : rebase #

Patch Set 5 : fix rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -11 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 4 chunks +3 lines, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 4 chunks +3 lines, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 4 chunks +3 lines, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 4 chunks +3 lines, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 4 chunks +3 lines, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 2 4 chunks +3 lines, -1 line 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 2 4 chunks +3 lines, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 4 chunks +3 lines, -1 line 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 2 4 chunks +3 lines, -1 line 0 comments Download
M test/mjsunit/es6/debug-stepin-proxies.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
Yang
4 years, 8 months ago (2016-04-21 12:03:17 UTC) #1
Michael Starzinger
LGTM.
4 years, 8 months ago (2016-04-21 12:31:02 UTC) #2
Yang
On 2016/04/21 12:31:02, Michael Starzinger wrote: > LGTM. The fix was wrong. I now fixed ...
4 years, 8 months ago (2016-04-21 12:56:28 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903223003/20001
4 years, 8 months ago (2016-04-21 13:00:44 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/529) v8_linux64_avx2_rel_ng_triggered on ...
4 years, 8 months ago (2016-04-21 13:16:03 UTC) #7
Michael Starzinger
LGTM on new approach as well.
4 years, 8 months ago (2016-04-21 16:18:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903223003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903223003/60001
4 years, 8 months ago (2016-04-22 09:29:31 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/585) v8_linux64_asan_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 8 months ago (2016-04-22 10:10:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903223003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903223003/80001
4 years, 8 months ago (2016-04-22 12:50:30 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-22 13:11:40 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:15:38 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/4b580cad0cc28c498aa3b7fe9ab8c991775b966f
Cr-Commit-Position: refs/heads/master@{#35729}

Powered by Google App Engine
This is Rietveld 408576698