Get skiaserve working on Windows.

Get skiaserve working on Windows.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1903203003

Committed: https://skia.googlesource.com/skia/+/82996b82005d54195d832bf6eb8e472af41a615a

[Brian Osman, 2016-04-20 14:41:26]

Description was changed from

==========
Get skiaserve working on Windows.

BUG=skia:
==========

to

==========
Get skiaserve working on Windows.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Brian Osman, 2016-04-20 14:45:06]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, ethannicholas@google.com, jcgregorio@google.com

[Brian Osman, 2016-04-20 14:45:07]

https://codereview.chromium.org/1903203003/diff/1/gyp/microhttpd.gyp
File gyp/microhttpd.gyp (right):

https://codereview.chromium.org/1903203003/diff/1/gyp/microhttpd.gyp#newcode204
gyp/microhttpd.gyp:204: #            "HAVE_POLL=0",
The W32 version of MHD_Config.h that ships with the library includes
HAVE_POLL=1, but that causes a bunch of problems. Additionally, the code (in
daemon.c) uses an #ifdef, rather than #if, so we can't do HAVE_POLL=0. In any
case, the library/executable work without it.

https://codereview.chromium.org/1903203003/diff/1/gyp/skiaserve.gyp
File gyp/skiaserve.gyp (right):

https://codereview.chromium.org/1903203003/diff/1/gyp/skiaserve.gyp#newcode51
gyp/skiaserve.gyp:51: 'ws2_32.lib',
I think this is the right place to do this? Or can/should I do this in
microhttpd.gyp?

[Brian Osman, 2016-04-20 14:45:15]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 14:45:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903203003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903203003/1

[commit-bot: I haz the power, 2016-04-20 14:54:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 14:54:31]

Dry run: This issue passed the CQ dry run.

[jcgregorio, 2016-04-20 15:13:38]

LGTM for everything but the gyp, which someone else should look at.

[bsalomon, 2016-04-20 15:40:55]

Perhaps most.gyp and everything.gyp should be modified to build skiaserve on
windows. This will make the bots build it.

https://codereview.chromium.org/1903203003/diff/20001/gyp/skiaserve.gyp
File gyp/skiaserve.gyp (right):

https://codereview.chromium.org/1903203003/diff/20001/gyp/skiaserve.gyp#newco...
gyp/skiaserve.gyp:48: 'msvs_settings': {
If it's a dependency of microhttpd then I think it should go in microhttpd's
gyp.

[Brian Osman, 2016-04-20 16:09:42]

On 2016/04/20 15:40:55, bsalomon wrote:
> Perhaps most.gyp and everything.gyp should be modified to build skiaserve on
> windows. This will make the bots build it.
> 
> https://codereview.chromium.org/1903203003/diff/20001/gyp/skiaserve.gyp
> File gyp/skiaserve.gyp (right):
> 
>
https://codereview.chromium.org/1903203003/diff/20001/gyp/skiaserve.gyp#newco...
> gyp/skiaserve.gyp:48: 'msvs_settings': {
> If it's a dependency of microhttpd then I think it should go in microhttpd's
> gyp.

Done. (It looks like everything.gyp currently depends on most and skiaserve, so
everything should have been trying to build it previously). Now it's included in
most, and the dependent win32 library is added by microphttpd.

[Brian Osman, 2016-04-20 16:19:01]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 16:19:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903203003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903203003/40001

[commit-bot: I haz the power, 2016-04-20 16:28:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 16:28:02]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-04-20 17:37:36]

lgtm

[Brian Osman, 2016-04-20 17:51:53]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-04-20 17:51:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
jcgregorio@google.com
Link to the patchset: https://codereview.chromium.org/1903203003/#ps40001
(title: "Fix ws2_32 dependency, build skiaserve w/most on windows")

[commit-bot: I haz the power, 2016-04-20 17:52:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903203003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903203003/40001

[commit-bot: I haz the power, 2016-04-20 17:52:56]

Description was changed from

==========
Get skiaserve working on Windows.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Get skiaserve working on Windows.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/82996b82005d54195d832bf6eb8e472af41a615a
==========

[commit-bot: I haz the power, 2016-04-20 17:52:57]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/82996b82005d54195d832bf6eb8e472af41a615a