Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1903203002: [WebView] Don't try to set cookies with null values. (Closed)

Created:
4 years, 8 months ago by Bernhard Bauer
Modified:
4 years, 8 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebView] Don't try to set cookies with null values. BUG=605556 Committed: https://crrev.com/72266b1cc2f117c2612514e53b6316bbec916a7e Cr-Commit-Position: refs/heads/master@{#388786}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/CookieManagerAdapter.java View 4 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903203002/1
4 years, 8 months ago (2016-04-20 15:07:50 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-20 15:50:37 UTC) #4
Bernhard Bauer
Please review.
4 years, 8 months ago (2016-04-20 16:51:05 UTC) #6
Torne
Code looks good but since the original CL making this crash went into M51 we ...
4 years, 8 months ago (2016-04-21 14:04:34 UTC) #7
Bernhard Bauer
On 2016/04/21 14:04:34, Torne wrote: > Code looks good but since the original CL making ...
4 years, 8 months ago (2016-04-21 15:02:59 UTC) #9
Torne
LGTM, thanks.
4 years, 8 months ago (2016-04-21 15:05:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903203002/1
4 years, 8 months ago (2016-04-21 15:07:17 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 16:25:51 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:35:11 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72266b1cc2f117c2612514e53b6316bbec916a7e
Cr-Commit-Position: refs/heads/master@{#388786}

Powered by Google App Engine
This is Rietveld 408576698