Look in all available CVC fields for a value for credit card upload.

Look in all available CVC fields for a value for credit card upload.

Previously, if there were multiple CVC fields and some were empty, we
would stop looking after encountering an empty one and assume that no
CVC value was available.

BUG=605230
Committed: https://crrev.com/287b714a776aeed97a653195b591583ef49c07c1
Cr-Commit-Position: refs/heads/master@{#388586}

[Justin Donnelly, 2016-04-20 19:43:07]

Description was changed from

==========
Look in all available CVC fields for a value for credit card upload.

Previously, if there were multiple CVC fields and some were empty, we
would have stopping looking after encountering an empty one and assumed
that no CVC value was available.

BUG=
==========

to

==========
Look in all available CVC fields for a value for credit card upload.

Previously, if there were multiple CVC fields and some were empty, we
would have stopping looking after encountering an empty one and assumed
that no CVC value was available.

BUG=605230
==========

[Justin Donnelly, 2016-04-20 19:43:46]

Description was changed from

==========
Look in all available CVC fields for a value for credit card upload.

Previously, if there were multiple CVC fields and some were empty, we
would have stopping looking after encountering an empty one and assumed
that no CVC value was available.

BUG=605230
==========

to

==========
Look in all available CVC fields for a value for credit card upload.

Previously, if there were multiple CVC fields and some were empty, we
would stop looking after encountering an empty one and assume that no
CVC value was available.

BUG=605230
==========

[Justin Donnelly, 2016-04-20 19:44:40]

jdonnelly@chromium.org changed reviewers:
+ mathp@chromium.org

[Justin Donnelly, 2016-04-20 19:46:47]

I also plan to change the metric as discussed earlier to distinguish between a)
no CVC fields are detected and b) CVC fields appear but don't have a value.

But I'd like to see the effect of this change, if any, first before changing the
metric.

[Mathieu, 2016-04-20 20:00:41]

lgtm with a question

https://codereview.chromium.org/1903183003/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_manager.cc (right):

https://codereview.chromium.org/1903183003/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_manager.cc:1079:
!field->value.empty()) {
note that this is still not fully robust (some fields will have "___" or some
stuff) but it's probably good. You could also try to StringToInt it. Up to you.

[Justin Donnelly, 2016-04-20 20:58:01]

https://codereview.chromium.org/1903183003/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_manager.cc (right):

https://codereview.chromium.org/1903183003/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_manager.cc:1079:
!field->value.empty()) {
On 2016/04/20 20:00:41, Mathieu Perreault wrote:
> note that this is still not fully robust (some fields will have "___" or some
> stuff) but it's probably good. You could also try to StringToInt it. Up to
you.

Good idea. Done.

[Mathieu, 2016-04-20 21:06:44]

lgtm

[Justin Donnelly, 2016-04-20 22:13:49]

The CQ bit was checked by jdonnelly@chromium.org

[commit-bot: I haz the power, 2016-04-20 22:14:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1903183003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1903183003/20001

[commit-bot: I haz the power, 2016-04-20 23:21:33]

Description was changed from

==========
Look in all available CVC fields for a value for credit card upload.

Previously, if there were multiple CVC fields and some were empty, we
would stop looking after encountering an empty one and assume that no
CVC value was available.

BUG=605230
==========

to

==========
Look in all available CVC fields for a value for credit card upload.

Previously, if there were multiple CVC fields and some were empty, we
would stop looking after encountering an empty one and assume that no
CVC value was available.

BUG=605230
==========

[commit-bot: I haz the power, 2016-04-20 23:21:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:26:49]

Description was changed from

==========
Look in all available CVC fields for a value for credit card upload.

Previously, if there were multiple CVC fields and some were empty, we
would stop looking after encountering an empty one and assume that no
CVC value was available.

BUG=605230
==========

to

==========
Look in all available CVC fields for a value for credit card upload.

Previously, if there were multiple CVC fields and some were empty, we
would stop looking after encountering an empty one and assume that no
CVC value was available.

BUG=605230

Committed: https://crrev.com/287b714a776aeed97a653195b591583ef49c07c1
Cr-Commit-Position: refs/heads/master@{#388586}
==========

[commit-bot: I haz the power, 2016-04-22 19:26:50]

Patchset 2 (id:??) landed as
https://crrev.com/287b714a776aeed97a653195b591583ef49c07c1
Cr-Commit-Position: refs/heads/master@{#388586}