Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 1903183002: [css-grid] Fix grid-template-columns|rows computed style with content alignment (Closed)

Created:
4 years, 8 months ago by Manuel Rego
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, svillar, blink-reviews-css, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, blink-reviews, eae+blinkwatch, blink-reviews-layout_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Fix grid-template-columns|rows computed style with content alignment Computed style of grid-template-columns and grid-template-rows properties was including the distribution offset because of content alignment. We should subtract that offset, like we do for the case of gaps, when we're calculating the computed style. BUG=521407 TEST=fast/css-grid-layout/grid-template-columns-rows-computed-style-gaps-content-alignment.html Committed: https://crrev.com/3cfbacf562e478c396f22a374d58e4ef35e321ee Cr-Commit-Position: refs/heads/master@{#388477}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
Manuel Rego
Pretty simple patch following a similar solution to what we already have for grid gaps.
4 years, 8 months ago (2016-04-20 11:05:14 UTC) #2
rune
lgtm
4 years, 8 months ago (2016-04-20 11:36:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903183002/1
4 years, 8 months ago (2016-04-20 11:42:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 12:45:29 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:22:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cfbacf562e478c396f22a374d58e4ef35e321ee
Cr-Commit-Position: refs/heads/master@{#388477}

Powered by Google App Engine
This is Rietveld 408576698