base/task_scheduler/scheduler_thread_pool_impl.h - Issue 1903133003: TaskScheduler: Avoid Sequence refcount bump in GetWork()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/task_scheduler/scheduler_thread_pool_impl.h

Issue 1903133003: TaskScheduler: Avoid Sequence refcount bump in GetWork() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: real CL and rebase after discussion #1-5 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/task_scheduler/priority_queue.cc ('K') | « base/task_scheduler/scheduler_thread_pool.h ('k') | base/task_scheduler/scheduler_thread_pool_impl.cc » ('j') | base/task_scheduler/scheduler_thread_pool_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/task_scheduler/scheduler_thread_pool_impl.h

diff --git a/base/task_scheduler/scheduler_thread_pool_impl.h b/base/task_scheduler/scheduler_thread_pool_impl.h

index 77cb4d8a44ecc16c9510acd9e4998f415ae3ce8c..4e282f1d55ff20c988ed2163e210d5a040e668f1 100644

--- a/base/task_scheduler/scheduler_thread_pool_impl.h

+++ b/base/task_scheduler/scheduler_thread_pool_impl.h

@@ -31,7 +31,6 @@ namespace base {

namespace internal {

class DelayedTaskManager;

-struct SequenceSortKey;

class TaskTracker;

// A pool of threads that run Tasks. This class is thread-safe.