Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: base/task_scheduler/sequence_sort_key.cc

Issue 1903133003: TaskScheduler: Avoid Sequence refcount bump in GetWork() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix compile (why did this compile locally?! Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/task_scheduler/sequence_sort_key.h" 5 #include "base/task_scheduler/sequence_sort_key.h"
6 6
7 namespace base { 7 namespace base {
8 namespace internal { 8 namespace internal {
9 9
10 SequenceSortKey::SequenceSortKey(TaskPriority priority, 10 SequenceSortKey::SequenceSortKey(TaskPriority priority,
11 TimeTicks next_task_sequenced_time) 11 TimeTicks next_task_sequenced_time)
12 : priority(priority), next_task_sequenced_time(next_task_sequenced_time) {} 12 : priority_(priority),
13 next_task_sequenced_time_(next_task_sequenced_time) {}
13 14
14 bool SequenceSortKey::operator<(const SequenceSortKey& other) const { 15 bool SequenceSortKey::operator<(const SequenceSortKey& other) const {
15 // This SequenceSortKey is considered less important than |other| if it has a 16 // This SequenceSortKey is considered less important than |other| if it has a
16 // lower priority or if it has the same priority but its next task was posted 17 // lower priority or if it has the same priority but its next task was posted
17 // later than |other|'s. 18 // later than |other|'s.
18 const int priority_diff = 19 const int priority_diff =
19 static_cast<int>(priority) - static_cast<int>(other.priority); 20 static_cast<int>(priority_) - static_cast<int>(other.priority_);
20 if (priority_diff < 0) 21 if (priority_diff < 0)
21 return true; 22 return true;
22 if (priority_diff > 0) 23 if (priority_diff > 0)
23 return false; 24 return false;
24 return next_task_sequenced_time > other.next_task_sequenced_time; 25 return next_task_sequenced_time_ > other.next_task_sequenced_time_;
25 } 26 }
26 27
27 } // namespace internal 28 } // namespace internal
28 } // namespace base 29 } // namespace base
OLDNEW
« no previous file with comments | « base/task_scheduler/sequence_sort_key.h ('k') | base/task_scheduler/sequence_sort_key_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698