Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: base/task_scheduler/scheduler_worker_thread_stack_unittest.cc

Issue 1903103007: TaskScheduler: Make SchedulerWorkerThread own its delegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sched_2b_remove_utils
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/scheduler_worker_thread_stack_unittest.cc
diff --git a/base/task_scheduler/scheduler_worker_thread_stack_unittest.cc b/base/task_scheduler/scheduler_worker_thread_stack_unittest.cc
index 9035428f1096f699ee5641b933be147f35f7f79f..b39243d05d81bb97d9166be923dbc7e94943a60f 100644
--- a/base/task_scheduler/scheduler_worker_thread_stack_unittest.cc
+++ b/base/task_scheduler/scheduler_worker_thread_stack_unittest.cc
@@ -5,6 +5,7 @@
#include "base/task_scheduler/scheduler_worker_thread_stack.h"
#include "base/logging.h"
+#include "base/memory/ptr_util.h"
#include "base/memory/ref_counted.h"
#include "base/task_scheduler/scheduler_worker_thread.h"
#include "base/task_scheduler/sequence.h"
@@ -34,14 +35,17 @@ class MockSchedulerWorkerThreadDelegate
class TaskSchedulerWorkerThreadStackTest : public testing::Test {
protected:
void SetUp() override {
- thread_a_ = SchedulerWorkerThread::CreateSchedulerWorkerThread(
- ThreadPriority::NORMAL, &delegate_, &task_tracker_);
+ thread_a_ = SchedulerWorkerThread::Create(
+ ThreadPriority::NORMAL,
+ WrapUnique(new MockSchedulerWorkerThreadDelegate), &task_tracker_);
ASSERT_TRUE(thread_a_);
- thread_b_ = SchedulerWorkerThread::CreateSchedulerWorkerThread(
- ThreadPriority::NORMAL, &delegate_, &task_tracker_);
+ thread_b_ = SchedulerWorkerThread::Create(
+ ThreadPriority::NORMAL,
+ WrapUnique(new MockSchedulerWorkerThreadDelegate), &task_tracker_);
ASSERT_TRUE(thread_b_);
- thread_c_ = SchedulerWorkerThread::CreateSchedulerWorkerThread(
- ThreadPriority::NORMAL, &delegate_, &task_tracker_);
+ thread_c_ = SchedulerWorkerThread::Create(
+ ThreadPriority::NORMAL,
+ WrapUnique(new MockSchedulerWorkerThreadDelegate), &task_tracker_);
ASSERT_TRUE(thread_c_);
}
@@ -56,7 +60,6 @@ class TaskSchedulerWorkerThreadStackTest : public testing::Test {
std::unique_ptr<SchedulerWorkerThread> thread_c_;
private:
- MockSchedulerWorkerThreadDelegate delegate_;
TaskTracker task_tracker_;
};
« no previous file with comments | « base/task_scheduler/scheduler_worker_thread.cc ('k') | base/task_scheduler/scheduler_worker_thread_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698