Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4518)

Unified Diff: base/task_scheduler/scheduler_worker_thread.cc

Issue 1903103007: TaskScheduler: Make SchedulerWorkerThread own its delegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sched_2b_remove_utils
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/scheduler_worker_thread.cc
diff --git a/base/task_scheduler/scheduler_worker_thread.cc b/base/task_scheduler/scheduler_worker_thread.cc
index 60d05e1ca7b97ec213e8c24f86534e54395f2282..827b17db96b5b7295e16f4bdb5858c05f2ea9645 100644
--- a/base/task_scheduler/scheduler_worker_thread.cc
+++ b/base/task_scheduler/scheduler_worker_thread.cc
@@ -15,12 +15,12 @@ namespace base {
namespace internal {
std::unique_ptr<SchedulerWorkerThread>
-SchedulerWorkerThread::CreateSchedulerWorkerThread(
- ThreadPriority thread_priority,
- Delegate* delegate,
- TaskTracker* task_tracker) {
+SchedulerWorkerThread::CreateWorkerThread(ThreadPriority thread_priority,
robliao 2016/04/22 20:30:48 While we're here, would Create(*) be sufficient as
fdoray 2016/04/22 22:46:46 Done. Also renamed SchedulerThreadPool::CreateThre
+ std::unique_ptr<Delegate> delegate,
+ TaskTracker* task_tracker) {
std::unique_ptr<SchedulerWorkerThread> worker_thread(
- new SchedulerWorkerThread(thread_priority, delegate, task_tracker));
+ new SchedulerWorkerThread(thread_priority, std::move(delegate),
+ task_tracker));
if (worker_thread->thread_handle_.is_null())
return nullptr;
@@ -45,10 +45,10 @@ void SchedulerWorkerThread::JoinForTesting() {
}
SchedulerWorkerThread::SchedulerWorkerThread(ThreadPriority thread_priority,
- Delegate* delegate,
+ std::unique_ptr<Delegate> delegate,
TaskTracker* task_tracker)
: wake_up_event_(false, false),
- delegate_(delegate),
+ delegate_(std::move(delegate)),
task_tracker_(task_tracker) {
DCHECK(delegate_);
DCHECK(task_tracker_);

Powered by Google App Engine
This is Rietveld 408576698