Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: src/external-reference-table.cc

Issue 1903093003: Reland of Change calling convention of CallApiGetterStub to accept the AccessorInfo (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/interface-descriptors-arm64.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/external-reference-table.cc
diff --git a/src/external-reference-table.cc b/src/external-reference-table.cc
index da48c13cfa39c9131a2ebe34ab6af6b02a4de528..20b524f16d7dd1174e64fb83ceb0f1a3edf98af9 100644
--- a/src/external-reference-table.cc
+++ b/src/external-reference-table.cc
@@ -297,19 +297,29 @@
const char* name;
};
- static const AccessorRefTable accessors[] = {
+ static const AccessorRefTable getters[] = {
#define ACCESSOR_INFO_DECLARATION(name) \
{FUNCTION_ADDR(&Accessors::name##Getter), "Accessors::" #name "Getter"},
ACCESSOR_INFO_LIST(ACCESSOR_INFO_DECLARATION)
#undef ACCESSOR_INFO_DECLARATION
+ };
+ static const AccessorRefTable setters[] = {
#define ACCESSOR_SETTER_DECLARATION(name) \
{FUNCTION_ADDR(&Accessors::name), "Accessors::" #name},
- ACCESSOR_SETTER_LIST(ACCESSOR_SETTER_DECLARATION)
+ ACCESSOR_SETTER_LIST(ACCESSOR_SETTER_DECLARATION)
#undef ACCESSOR_INFO_DECLARATION
};
- for (unsigned i = 0; i < arraysize(accessors); ++i) {
- Add(accessors[i].address, accessors[i].name);
+ for (unsigned i = 0; i < arraysize(getters); ++i) {
+ Add(getters[i].address, getters[i].name);
+#ifdef USE_SIMULATOR
+ Add(AccessorInfo::redirect(isolate, getters[i].address, ACCESSOR_GETTER),
+ getters[i].name);
+#endif
+ }
+
+ for (unsigned i = 0; i < arraysize(setters); ++i) {
+ Add(setters[i].address, setters[i].name);
}
StubCache* stub_cache = isolate->stub_cache();
« no previous file with comments | « src/arm64/interface-descriptors-arm64.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698