Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1903013002: media: Check StartThread() result in AVDATimerManager. (Closed)

Created:
4 years, 8 months ago by xhwang
Modified:
4 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Check StartThread() result in AVDATimerManager. Also check that AVDATimerManager is only accessed on one thread. BUG=604869 TEST=No functionality change. Committed: https://crrev.com/f9f18e9cb49ccea7aabd92f4396ba408b404ba05 Cr-Commit-Position: refs/heads/master@{#388540}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M content/common/gpu/media/android_video_decode_accelerator.cc View 1 7 chunks +24 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
xhwang
I don't think this CL fixes the bug, but is the good thing to do ...
4 years, 8 months ago (2016-04-19 22:37:28 UTC) #2
xhwang
PTAL
4 years, 8 months ago (2016-04-19 22:37:41 UTC) #3
watk
lgtm
4 years, 8 months ago (2016-04-19 22:59:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903013002/20001
4 years, 8 months ago (2016-04-19 23:08:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/170582)
4 years, 8 months ago (2016-04-19 23:16:45 UTC) #8
watk
Oh yeah, Dale said he was going to add me as an OWNER but mustn't ...
4 years, 8 months ago (2016-04-19 23:17:40 UTC) #9
xhwang
sandersd: Please OWNERS review :)
4 years, 8 months ago (2016-04-19 23:31:05 UTC) #11
sandersd (OOO until July 31)
rs lgtm
4 years, 8 months ago (2016-04-20 18:25:37 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-20 18:39:20 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:25:05 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f9f18e9cb49ccea7aabd92f4396ba408b404ba05
Cr-Commit-Position: refs/heads/master@{#388540}

Powered by Google App Engine
This is Rietveld 408576698