Stop resolving classes prematurely in the vm (issue 11023).

runtime/vm/object.cc

Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc	(revision 24923)
+++ runtime/vm/object.cc	(working copy)
@@ -6662,6 +6662,7 @@
 }
 
 
+// TODO(regis): This should take an Error* ambiguity_error parameter.
 RawObject* Library::LookupObject(const String& name) const {
   // First check if name is found in the local scope of the library.
   Object& obj = Object::Handle(LookupLocalObject(name));
@@ -6669,6 +6670,8 @@
     return obj.raw();
   }
   // Now check if name is found in any imported libs.
+  // TODO(regis): This does not seem correct. It should be an error if the name
+  // is found in more than one import and actually used.

[hausner, 2013/07/11 22:18:27]

This error check is done in the parser. It verifies that a name is not
ambiguous. See Parser::ResolveNameInCurrentLibraryScope().

[regis, 2013/07/12 00:02:38]

Understood. My comment relates to the fact that this function cannot be used by
itself, since it does not detect ambiguities. I will rewrite it in another cl.

   const Array& imports = Array::Handle(this->imports());
   Namespace& import = Namespace::Handle();
   for (intptr_t j = 0; j < this->num_imports(); j++) {
@@ -6682,6 +6685,7 @@
 }
 
 
+// TODO(regis): This should take an Error* ambiguity_error parameter.
 RawClass* Library::LookupClass(const String& name) const {
   Object& obj = Object::Handle(LookupObject(name));
   if (!obj.IsNull() && obj.IsClass()) {