Stop resolving classes prematurely in the vm (issue 11023).

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 6644 matching lines @@
   }
   if (obj.IsFunction()) {
     return Function::Cast(obj).raw();
   }
 
   // No function found.
   return Function::null();
 }
 
 
+// TODO(regis): This should take an Error* ambiguity_error parameter.
 RawObject* Library::LookupObject(const String& name) const {
   // First check if name is found in the local scope of the library.
   Object& obj = Object::Handle(LookupLocalObject(name));
   if (!obj.IsNull()) {
     return obj.raw();
   }
   // Now check if name is found in any imported libs.
+  // TODO(regis): This does not seem correct. It should be an error if the name
+  // is found in more than one import and actually used.

[hausner, 2013/07/11 22:18:27]

This error check is done in the parser. It verifies that a name is not
ambiguous. See Parser::ResolveNameInCurrentLibraryScope().

[regis, 2013/07/12 00:02:38]

Understood. My comment relates to the fact that this function cannot be used by
itself, since it does not detect ambiguities. I will rewrite it in another cl.

   const Array& imports = Array::Handle(this->imports());
   Namespace& import = Namespace::Handle();
   for (intptr_t j = 0; j < this->num_imports(); j++) {
     import ^= imports.At(j);
     obj = import.Lookup(name);
     if (!obj.IsNull()) {
       return obj.raw();
     }
   }
   return Object::null();
 }
 
 
+// TODO(regis): This should take an Error* ambiguity_error parameter.
 RawClass* Library::LookupClass(const String& name) const {
   Object& obj = Object::Handle(LookupObject(name));
   if (!obj.IsNull() && obj.IsClass()) {
     return Class::Cast(obj).raw();
   }
   return Class::null();
 }
 
 
 RawClass* Library::LookupLocalClass(const String& name) const {
@@ skipping 7450 matching lines @@
 }
 
 
 void MirrorReference::PrintToJSONStream(JSONStream* stream, bool ref) const {
   stream->OpenObject();
   stream->CloseObject();
 }
 
 
 }  // namespace dart