Upgrade pub to work with crypto 1.0.0 or later.

Upgrade pub to work with crypto 1.0.0 or later.

This is necessary since the SDK's repo requires that.

R=kevmoo@google.com

Committed: https://github.com/dart-lang/pub/commit/217fc8ae2bdee58ebf4b11a6fa3d49624d90c0c4

[Bob Nystrom, 2016-04-19 23:41:59]

rnystrom@google.com changed reviewers:
+ kevmoo@google.com, nweiz@google.com

[kevmoo, 2016-04-20 01:00:45]

lgtm

[Bob Nystrom, 2016-04-20 01:30:24]

Description was changed from

==========
Upgrade pub to work with crypto 1.0.0 or later.

This is necessary since the SDK's repo requires that.
==========

to

==========
Upgrade pub to work with crypto 1.0.0 or later.

This is necessary since the SDK's repo requires that.

R=kevmoo@google.com

Committed:
https://github.com/dart-lang/pub/commit/217fc8ae2bdee58ebf4b11a6fa3d49624d90c0c4
==========

[Bob Nystrom, 2016-04-20 01:30:25]

Committed patchset #1 (id:1) manually as
217fc8ae2bdee58ebf4b11a6fa3d49624d90c0c4 (presubmit successful).

[nweiz, 2016-04-21 19:04:38]

https://codereview.chromium.org/1902993003/diff/1/lib/src/utils.dart
File lib/src/utils.dart (right):

https://codereview.chromium.org/1902993003/diff/1/lib/src/utils.dart#newcode12
lib/src/utils.dart:12: import "package:crypto/crypto.dart" as crypto;
crypto is not intended to be imported with a prefix.

https://codereview.chromium.org/1902993003/diff/1/lib/src/utils.dart#newcode491
lib/src/utils.dart:491: hex.encode(crypto.sha1.convert(source.codeUnits).bytes);
    crypto.sha1.convert(UTF8.encode(source)).toString()

Digest.toString() provides a hex representation, sha1 expects bytes, not
arbitrary integers.

https://codereview.chromium.org/1902993003/diff/1/lib/src/utils.dart#newcode493
lib/src/utils.dart:493: /// Returns the base64-encoded sha1 hash of [stream].
Why is this base64-encoded rather than hex-encoded?

[Bob Nystrom, 2016-04-21 20:23:20]

https://codereview.chromium.org/1902993003/diff/1/lib/src/utils.dart
File lib/src/utils.dart (right):

https://codereview.chromium.org/1902993003/diff/1/lib/src/utils.dart#newcode12
lib/src/utils.dart:12: import "package:crypto/crypto.dart" as crypto;
On 2016/04/21 19:04:38, nweiz wrote:
> crypto is not intended to be imported with a prefix.

Pub defines a sha1() function so I needed to disambiguate it and this seemed the
least innocuous.

https://codereview.chromium.org/1902993003/diff/1/lib/src/utils.dart#newcode491
lib/src/utils.dart:491: hex.encode(crypto.sha1.convert(source.codeUnits).bytes);
On 2016/04/21 19:04:38, nweiz wrote:
>     crypto.sha1.convert(UTF8.encode(source)).toString()
> 
> Digest.toString() provides a hex representation, sha1 expects bytes, not
arbitrary integers.

TIL. Done. I'll send out a code review.

https://codereview.chromium.org/1902993003/diff/1/lib/src/utils.dart#newcode493
lib/src/utils.dart:493: /// Returns the base64-encoded sha1 hash of [stream].
On 2016/04/21 19:04:38, nweiz wrote:
> Why is this base64-encoded rather than hex-encoded?

It's annoying that this is different from the previous function, but it
preserves the same behavior we had before when this code was in barback_server.
I was trying to minimize the effect of this change since it's getting
cherry-picked. (I also think base64 is a better answer here since it leads to a
shorter string for something where minimizing transfer size is the main goal.)