scripts/slave/recipe_modules/chromium_tests/steps.py - Issue 1902983002: Revert of Switch Android gtests to use generated wrapper scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/steps.py

Issue 1902983002: Revert of Switch Android gtests to use generated wrapper scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium_android/example.expected/webview_tester_basic.json ('k') | scripts/slave/recipe_modules/cronet/example.expected/local_test.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium_tests/steps.py

diff --git a/scripts/slave/recipe_modules/chromium_tests/steps.py b/scripts/slave/recipe_modules/chromium_tests/steps.py

index f45e8a4052fadc972e7549de8c175fda4e74db99..1f3c92f2a29c43ed1b1e4726215049d7820b473a 100644

--- a/scripts/slave/recipe_modules/chromium_tests/steps.py

+++ b/scripts/slave/recipe_modules/chromium_tests/steps.py

@@ -273,8 +273,6 @@

return self._override_compile_targets

if api.chromium.c.TARGET_PLATFORM == 'android':

- # TODO(agrieve): Remove _apk suffix in favour of bin/run_${target} once

- # GYP is gone. http://crbug.com/599919

return [self.target_name + '_apk']

return [self.target_name]

@@ -826,8 +824,6 @@

return [self.target_name, self.target_name + '_run']

def isolate_target(self, api):

- # TODO(agrieve): Remove _apk suffix in favour of bin/run_${target} once

- # GYP is gone. http://crbug.com/599919

if api.chromium.c.TARGET_PLATFORM == 'android':

return self.target_name + '_apk'

return self.target_name