[Streams] UnderlyingSourceBase should be kept alive only when locked

third_party/WebKit/Source/core/streams/ReadableStream.js

Index: third_party/WebKit/Source/core/streams/ReadableStream.js
diff --git a/third_party/WebKit/Source/core/streams/ReadableStream.js b/third_party/WebKit/Source/core/streams/ReadableStream.js
index 414c92343120fd65d3d7f87f4c38c6ffede89c77..bb8204fca08e51ca93c1e6925ba9911ff9c2d329 100644
--- a/third_party/WebKit/Source/core/streams/ReadableStream.js
+++ b/third_party/WebKit/Source/core/streams/ReadableStream.js
@@ -276,6 +276,17 @@
         throw new TypeError(errReaderConstructorStreamAlreadyLocked);
       }
 
+      // TODO(yhirano): Remove this when we don't need hasPendingActivity in
+      // blink::UnderlyingSourceBase.
+      if (stream[readableStreamController] === null) {
+        // The stream is created with an external controller (i.e. made in
+        // Blink).
+        CallOrNoop(

[domenic, 2016/04/20 20:38:04]

Should be `const underlyingSource = stream[readableStreamUnderlyingSource];
callFunction(underlyingSource.notifyLockAcquired, underlyingSource)`. No need
for the extra checks/fallback CallOrNoop does. (Same below.)

[yhirano, 2016/04/21 01:50:50]

Done.

+            stream[readableStreamUnderlyingSource],
+            'notifyLockAcquired',
+            'underlyingSource.notifyLockAcquired');
+      }
+
       this[readableStreamReaderOwnerReadableStream] = stream;
       stream[readableStreamReader] = this;
 
@@ -342,6 +353,17 @@
         throw new TypeError(errReleaseReaderWithPendingRead);
       }
 
+      // TODO(yhirano): Remove this when we don't need hasPendingActivity in
+      // blink::UnderlyingSourceBase.
+      if (stream[readableStreamController] === null) {
+        // The stream is created with an external controller (i.e. made in
+        // Blink).
+        CallOrNoop(
+            stream[readableStreamUnderlyingSource],
+            'notifyLockReleased',
+            'underlyingSource.notifyLockReleased');
+      }
+
       if (stream[readableStreamState] === STATE_READABLE) {
         v8.rejectPromise(this[readableStreamReaderClosedPromise],
             new TypeError(errReleasedReaderClosedPromise));