Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 1902913002: Provide web contents to Chrome's mojo services (Closed)

Created:
4 years, 8 months ago by please use gerrit instead
Modified:
4 years, 8 months ago
Reviewers:
Ted C
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Provide web contents to Chrome's mojo services For the mojo service implementations in Chrome that fulfill tasks for render frames, the ChromeServiceRegistrar should provide the WebContents object that corresponds to the render frame that requested the service. This allows the service implementation to access WebContents-specific data and show UI on top of the WebContents. This patch also renames PaymentRequestDialog.java into PaymentRequestImpl.java, because it implements the mojo PaymentRequest service, while the UI functionality is implemented in a separate class. BUG=587995 Committed: https://crrev.com/6ebc6f22f9eb3c0ebda41830f1aae1e225141a8e Cr-Commit-Position: refs/heads/master@{#388310}

Patch Set 1 #

Messages

Total messages: 16 (11 generated)
please use gerrit instead
tedchoc@, ptal.
4 years, 8 months ago (2016-04-19 18:41:25 UTC) #9
Ted C
lgtm
4 years, 8 months ago (2016-04-19 20:18:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902913002/1
4 years, 8 months ago (2016-04-19 21:08:27 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 21:13:47 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:16:23 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ebc6f22f9eb3c0ebda41830f1aae1e225141a8e
Cr-Commit-Position: refs/heads/master@{#388310}

Powered by Google App Engine
This is Rietveld 408576698