Receive intent callbacks without launching intents

ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.ui.base;
 
 import android.app.Activity;
 import android.app.PendingIntent;
 import android.content.ActivityNotFoundException;
 import android.content.Context;
@@ skipping 112 matching lines @@
             activity.startActivityForResult(intent, requestCode);
         } catch (ActivityNotFoundException e) {
             return START_INTENT_FAILURE;
         }
 
         storeCallbackData(requestCode, callback, errorId);
         return requestCode;
     }
 
     @Override
+    public int addIntentCallback(IntentCallback callback, Integer errorId) {

[Ted C, 2016/04/19 21:30:24]

I'd be tempted to do something more like this:

public int showCancelableIntent(
        Callback<Integer> intentTrigger, IntentCallback callback, Integer
errorId) {
    Activity activity = getActivity().get();
    if (activity == null) return START_INTENT_FAILURE;

    int requestCode = generateNextRequestCode();

    intentTrigger.onResult(requestCocde);

    storeCallbackData(requestCode, callback, errorId);
    return requestCode;
}

A bit more verbose but it keeps this in line w/ the above calls.  I don't feel
too strongly though as they both aren't exactly ideal.

+        Activity activity = getActivity().get();
+        if (activity == null) return START_INTENT_FAILURE;
+
+        int requestCode = generateNextRequestCode();
+
+        storeCallbackData(requestCode, callback, errorId);
+        return requestCode;
+    }
+
+    @Override
     public void cancelIntent(int requestCode) {
         Activity activity = getActivity().get();
         if (activity == null) return;
         activity.finishActivity(requestCode);
     }
 
     /**
      * Responds to the intent result if the intent was created by the native window.
      * @param requestCode Request code of the requested intent.
      * @param resultCode Result code of the requested intent.
@@ skipping 173 matching lines @@
             Activity activity = getActivity().get();
             if (activity == null) return false;
 
             int requestCode = generateNextRequestCode();
             mOutstandingPermissionRequests.put(requestCode, callback);
             activity.requestPermissions(permissions, requestCode);
             return true;
         }
     }
 }